Repository navigation
Run a simulation on a single forecast window - #1692
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InfrastructureSystems records a single-window forecast's interval as an empty period, since there is no next window.
determine_intervalsrejected that withInvalidValue("Model UC interval not set correctly").A single-window model now steps by its forecast horizon; asking for more steps than windows still fails at build with
ConflictingInputsError.Testing
Adds two testsets to
test_simulation_build.jlon a one-bus, one-window system.Before the fix the one-step simulation throws
InvalidValue; after it, all 38 tests in the file pass (with #1690 and #1691 applied).🤖 Generated with Claude Code