Repository navigation
Follow the IOM and POM main APIs - #1691
Merged
Merged
Conversation
This was referenced Oct 10, 2026
- _apply_warm_start! reads the value of every variable first and then sets the start values. Setting a start value makes JuMP report OPTIMIZE_NOT_CALLED, so each read after the first set returned NaN. HiGHS rejected the NaN starts, and the events simulations failed. - The store writer copies the aux variable values. IOM.lookup_value returns the container's own aux array, which the next solve changes in place. The in-memory store kept that reference, so the stored aux values changed after the write.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
IOM.lookup_valuein the store writer and the warm start.IOM no longer defines
isemptyforPrimalValuesCache, so every simulation failed writing its first results.lookup_valuereads the values cached after a MILP's dual computation and falls back to the solver otherwise.Parameters keep
calculate_parameter_values.POM.get_branch_catalog.The update read
network_model.network_reduction, whichNetworkModelno longer has, so a simulation with branch rating series failed at step 2.Adds
test/test_branch_rating_time_series_simulation.jl: a two-step ED onc_sys5_edwith a PTDF network and a rating forecast on one line, checking the second step holds the second window's rating.Testing
Depends on #1690; the suite does not load without it.
With both: 18162 pass, 106 fail, 211 error; the remaining failures are listed in that PR.
The new branch-rating test passes (4/4). It cannot be shown failing in isolation, because without the
lookup_valuechange the simulation fails earlier.🤖 Generated with Claude Code