[Tests] Refactor theme-command.test.ts to use real temp dirs#7994
[Tests] Refactor theme-command.test.ts to use real temp dirs#7994gonzaloriestra wants to merge 1 commit into
Conversation
Refactored theme command tests to remove global filesystem mocks and instead use real filesystem operations within temporary directories. Introduced a `withThemeEnvironment` helper to reduce boilerplate and ensure proper isolation for each test case. Verified that all 36 tests pass and coverage is maintained.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Following the testing protocol to replace filesystem mocks with real temporary directories for better test reliability and isolation.
WHAT is this pull request doing?
packages/theme/src/cli/utilities/theme-command.test.tsto removevi.mock('@shopify/cli-kit/node/fs').withThemeEnvironmenthelper to wrap tests ininTemporaryDirectoryand mockcwd()to point to the temp dir.cwd()for default flag values.How to test your changes?
CI
Post-release steps
N/A
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 12932754602815531784 started by @gonzaloriestra