[Refactor] Use flatMap in asHumanFriendlyArray#7987
Conversation
- Modernized asHumanFriendlyArray in packages/cli-kit to use a more declarative flatMap implementation. - Added a full test suite for asHumanFriendlyArray in packages/cli-kit/src/public/common/array.test.ts covering empty, single, double, and multi-item arrays.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
asHumanFriendlyArrayutility in@shopify/cli-kitwas implemented using a manualreduceloop. Modernizing it to useflatMapimproves readability and intent. Additionally, this utility lacked dedicated unit tests.WHAT is this pull request doing?
asHumanFriendlyArrayinpackages/cli-kit/src/public/common/array.tsto useflatMap.packages/cli-kit/src/public/common/array.test.tscovering various array sizes and content types (strings, objects).How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 3153496017391173437 started by @gonzaloriestra