Repository navigation
Conversation
revam
added this pull request to stack #1490
October 3, 2026 17:38
harshithmohan
force-pushed
the
split/05-filters
branch
from
October 3, 2026 17:43
fe7c80f to
54a57b2
Compare
revam
force-pushed
the
split/05-filters
branch
from
October 3, 2026 18:48
54a57b2 to
1e9e38c
Compare
revam
force-pushed
the
split/04-configuration-secrets
branch
from
October 3, 2026 18:48
2eec211 to
81d9997
Compare
harshithmohan
force-pushed
the
split/05-filters
branch
2 times, most recently
from
October 4, 2026 06:27
728284d to
d093f78
Compare
harshithmohan
force-pushed
the
split/05-filters
branch
from
October 4, 2026 08:00
d093f78 to
71ec5a4
Compare
harshithmohan
force-pushed
the
split/05-filters
branch
from
October 5, 2026 17:32
71ec5a4 to
4acdb5f
Compare
harshithmohan
removed this pull request from stack #1490
October 5, 2026 17:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The filter editor mishandled conditions with two parameters: it offered the wrong picker for
HasSourceGenre/HasSourceTagand dropped the second value of others on save.What changed
PairCriteriaModal: listsPossibleParameterPairswhen the server sends them, so picks carry both values.HasCharacterWithAppearance,HasCreatorWithRole), two inputs: the first fromPossibleParameterswhen sent, the second free text suggestingPossibleSecondParameters(Inputtakes alistfor that).filterTree.Where to look first
src/core/utilities/filterTree.ts: how pairs map back to a condition's parameters.src/components/Collection/Filter/PairCriteriaModal.tsx: the new picker.Feedback wanted
UX of the pair picker and of the two free inputs.
Left to do
Character and creator filters take free text, as the server sends no possible parameters for them; a search-backed picker would fit them better.
Stack
Part 5 of 12 in the split of #1477. Below: Part 4, hidden secrets in configuration forms. Above: Part 6, the restart reasons and the server version bump.
Testing
pnpm tscheck,pnpm lint,pnpm testandpnpm buildpass at this branch's tip. Manual, on 6.0.0-dev.495: add aHasSourceTagcondition, save, reopen, and edit it again.