Repository navigation
fix(configuration): never show a stored secret in a configuration form - #1481
Merged
Merged
Conversation
revam
added this pull request to stack #1490
October 3, 2026 17:38
harshithmohan
force-pushed
the
split/04-configuration-secrets
branch
from
October 3, 2026 17:43
161b242 to
2eec211
Compare
revam
force-pushed
the
split/04-configuration-secrets
branch
from
October 3, 2026 18:48
2eec211 to
81d9997
Compare
harshithmohan
force-pushed
the
split/04-configuration-secrets
branch
from
October 4, 2026 06:14
81d9997 to
09b6971
Compare
- Rendered the `password` element type as a masked input, empty with an "Unchanged (hidden)" placeholder while the server sends `***SECRET-UNCHANGED…***`, which went into a text box before - Sent the masked value back when the field is left alone, so the server keeps the secret, what was typed otherwise, and an empty string when cleared - Added a clear button for a stored secret, an undo back to it, and a show/hide toggle for what was typed
harshithmohan
force-pushed
the
split/04-configuration-secrets
branch
from
October 4, 2026 06:27
09b6971 to
f287d1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Configuration forms put the server's masked placeholder for a stored secret (
***SECRET-UNCHANGED…***) into a plain text box.What changed
DynamicFieldrenders thepasswordelement type with the newPasswordField: masked, empty, with an "Unchanged (hidden)" placeholder while a secret is stored.Note for review: Touches how secrets are sent back to the server: the field never shows a stored secret, and only sends one when it was typed.
Where to look first
src/components/Dynamic/PasswordField.tsx: the whole behaviour.Feedback wanted
Whether keeping, replacing and clearing a secret are clear enough from the field alone.
Stack
Part 4 of 12 in the split of #1477. Below: Part 3, the SignalR event names. Above: Part 5, two-parameter filter conditions.
Testing
pnpm tscheck,pnpm lint,pnpm testandpnpm buildpass at this branch's tip. Manual, on 6.0.0-dev.495: a plugin configuration with a secret; save without touching it, then clear it, then replace it.