fix(web): truthful operator status and save feedback across the server pages by dorkmo · Pull Request #317 · SenaxInc/SenaxTankAlarm

dorkmo · 2026-09-14T14:31:47Z

Stacked PR. Base branch is website-config-roundtrip-calibration (#316). Merge order: #314 → #315 → #316 → this PR. This PR's diff shows only its own changes.

Summary

Third website PR from the 2026-09 master review: S-W06 (operator status can be misleading) and S-W07 (logs, save feedback, secondary API usability). All changes are in TankAlarm-112025-Server-BluesOpta.ino; the server-side parts are small, targeted handler fixes.

S-W06 — operator status

Item	Before	After
Float switches on the dashboard (M-30)	"Tank Level" card, value `--` for OFF, an `in/24h` delta and a trend sparkline	"Float Switch" card reading ON / OFF, no delta, no sparkline
Level of exactly 0 in	`--` (indistinguishable from no data)	`0.0"`
"Update requested" pill (M-31)	never expired; an unreachable client kept the dashboard on 10 s polling and hid the Update button for good	expires after the client's reply window (10 min grid / 60 min solar); the button returns as Retry Update with a tooltip and polling drops back to normal
`/api/clients` client-level `at` (M-41)	overwritten by whichever sensor reported last, so a multi-sensor client could show "ALARM: clear"	kept for the sensor in alarm
Site Config sensor rows (L-25)	the `ts[]` mapper dropped `flt`/`ma`, so the FAULT badge and mA readout were dead and a current-loop fault rendered as a number	fault string and mA mapped; float switches read ON/OFF
Outdated-client banner (L-51)	counted any client whose version string differed from the release, including newer ones	uses the sketch's existing `compareFirmwareVersions()`; only older-than counts
Client Console "Approve Deletion"	prompted for the admin PIN although `requireValidPin()` validates the session and ignores the value	a confirm dialog, like the dashboard's Remove Client

S-W07 — logs, feedback, secondary APIs

Transmission Log (M-26, M-27): filter options are built from the vocabulary logTransmission() emits (13 types, 14 statuses) plus whatever the loaded entries contain, so error, ota, alarm, applied, stalled… are selectable and no option is dead. The CSV export now uses the same filtered set as the table, including the detail-text search it used to omit. Badge colours added for error, applied, stalled.
saved:false (M-57): Contacts and Server Settings show an error toast ("saved in memory only, lost at the next reboot") when the server reports the flash write failed, instead of "saved successfully".
Overlong settings (M-58): GitHub route alias, FTP user and FTP password return 400 … too long (max 31 characters) instead of being silently cut; the inputs carry maxlength="31".
GET /api/location (M-61): the client= parameter goes through getQueryParam() (URL-decoded), so dev%3A… matches the stored UID and the Client Console location readout works for real UIDs.
Year-over-year history (L-49): ?sensor= splits at the last colon.
Login (L-22): anything other than a 401 shows the server's text (the 429 lockout countdown, the first-login "set a 4-digit PIN" message, or Login failed (HTTP n)); 401 still reads "Invalid PIN".
Config Generator (L-19, L-20, L-21): ?uid= for a client with no snapshot (404 or no config) starts a new configuration with the UID filled in and one sensor card, with an explanatory toast; Add Sensor stops at 8 with a toast, collectConfig refuses more, and handleConfigPost rejects a config with more than 8 sensors (the client keeps MAX_MONITORS = 8 and dropped the rest); if the contacts directory has not loaded, the download is refused and the load retried instead of deriving the daily report time from a hard-coded 05:00 UTC.
Server Settings (L-18): settings load once per page open (one /api/clients?summary=1 fetch measured) instead of twice.

Verification

Browser, against a loopback fixture serving the pages extracted from this branch (placeholder data), zero error events on every page exercised:

Dashboard cards: Float Switch / OFF with no delta or sparkline; pressure tank in alarm shows ALARM: HIGH; a request older than its window renders Retry Update with the tooltip, a 100 s-old one renders the ETA pill.
Site Config rows: 40.0 in 12.50 mA, OFF, FAULT OPEN.
Transmission Log: 6 fixture entries; status = error → 1 row; search "needle" (detail only) → 1 row and the CSV export has exactly that row.
Login: 1111 → "Invalid PIN", 9999 → "Too many failed attempts. Try again in 30 seconds", 0000 → "Please set a 4-digit PIN on first login".
Contacts: a schedule change against a saved:false reply shows the in-memory-only error toast.
Config Generator: ?uid=dev:000000000009 (404) → UID filled, one card, commissioning toast; nine Add Sensor clicks → 8 cards and the cap toast.
Client Console: approveDeletion calls confirm, never prompt, and sends {"client":"…"} only.
Server Settings: one /api/clients?summary=1 request; maxlength 31 on the three inputs.
Compile at arduino:mbed_opta 4.5.0, --warnings all: 1,028,012 B (52%) flash on this stacked branch (+2984 B over fix(web): lossless config generator round-trips and calibration sensor identity #316; the same change on a master base measured +2,984 B), 360,720 B (68%) static RAM (unchanged); warning set identical to the master build (line numbers aside). CI's compile-check and check-web-pages both pass on this PR.
check_web_pages.py (from fix(web): bind six dead controls programmatically, restrict client UIDs, clamp config inputs, add page checker to CI #315): every <script> block on all 18 pages passes node --check, 0 problems.