FIX: return early in Mahalanobis.fit when cat_vars is None (closes #905)#953
Open
Ebube22 wants to merge 4 commits into
Open
FIX: return early in Mahalanobis.fit when cat_vars is None (closes #905)#953Ebube22 wants to merge 4 commits into
Ebube22 wants to merge 4 commits into
Conversation
…ldonIO#905) Log a warning and skip fitting if no categorical variables are specified.
… None Add test for Mahalanobis fit method handling of None cat_vars.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #905
Problem
The fit method raised a TypeError when cat_vars is None, but both
the docstring and documentation explicitly state that this step is
not necessary in the absence of categorical variables.
Fix
Replace the TypeError with a logging.warning() and early return,
consistent with the documented behaviour.
Testing
Added a unit test (test_mahalanobis_fit_no_cat_vars_warns_and_returns)
confirming fit() warns and returns early without raising, and that
d_abs remains unchanged.