test: add missing dev deps and point Ollama tests at glm-5.3-flash:cloud - #1152
Open
techaboo wants to merge 1 commit into
Open
test: add missing dev deps and point Ollama tests at glm-5.3-flash:cloud#1152techaboo wants to merge 1 commit into
techaboo wants to merge 1 commit into
Conversation
Add pandas, selenium, and langchain-fireworks as dev dependencies so the corresponding test suites can run instead of failing on ImportError. Also swap the local-only ollama/mistral model in the Ollama-backed graph tests for ollama/glm-5.3-flash:cloud, since the local mistral model isn't available in this environment. Claude-Session: https://claude.ai/code/session_01CzfyyFKPjehQ2Xk1offTbn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pandas,selenium, andlangchain-fireworksas dev dependencies so their corresponding test files run instead of failing onImportError.smart_scraper_ollama_test.py,scrape_xml_ollama_test.py,script_generator_test.py) atollama/glm-5.3-flash:cloudinstead of the local-onlyollama/mistral, since a locally-pulledmistralmodel isn't available in this environment.Test plan
uv syncinstalls cleanlyhttps://claude.ai/code/session_01CzfyyFKPjehQ2Xk1offTbn