fix: add override_version for ansible-lint steps - #95
Open
adrienbourroux wants to merge 2 commits into
Open
Conversation
adrienbourroux
force-pushed
the
fix/75/composite-action-version-resolution
branch
from
August 7, 2026 07:11
cf52e0d to
9f66305
Compare
adrienbourroux
marked this pull request as ready for review
August 7, 2026 07:13
EtienneM
requested changes
Aug 7, 2026
| if: ${{ inputs.files == '' }} | ||
| uses: ansible/ansible-lint@262624cd0ab22a4221293216856c59671ce7aa5e # v26.6.0 | ||
| with: | ||
| override_version: 262624cd0ab22a4221293216856c59671ce7aa5e |
Member
There was a problem hiding this comment.
question: I don't understand the purpose of this instruction. Ca you explain?
Contributor
Author
There was a problem hiding this comment.
Without it, in this nested composite action, github.action_ref incorrectly resolves to the parent Scalingo/actions commit. ansible-lint then uses that SHA to build a URL against its own repository, which results in a 404.
example in https://github.com/Scalingo/scalingo-ansible/actions/runs/31154931231/job/92792260688?pr=358
Contributor
Author
There was a problem hiding this comment.
@EtienneM I added a comment to explain why override_version is needed. Is it clear enough now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ansible-lint version resolution in nested composite actions
When ansible-lint is invoked from this composite action, github.action_ref is not resolved correctly in the nested composite action case. As a result, the upstream action can fail to determine the expected pinned version. Passing override_version explicitly avoids that lookup and forces the correct version
Example of failure to be fixed by this
https://github.com/Scalingo/scalingo-ansible/actions/runs/31154931231/job/92792260688?pr=358