feat: import logs from Google Cloud Logging#32
Draft
STRRL wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Logs must be manually exported and uploaded (or piped via stdin) before LAPP can analyze them. There is no direct way to pull logs from Google Cloud Logging in either the CLI or the web UI.
Solution
Add a GCP log import path that fetches Cloud Logging entries via ADC and lands them as regular files in the workspace logs directory, so the existing discovery pipeline works unchanged. Web UI runs it as an async ImportRun job reusing the DiscoveryRun job pattern; CLI runs it synchronously.
Major Changes
import-runs/<id>/run.jsonwith QUEUED/RUNNING/SUCCEEDED/FAILED states, progress, and startup recovery marking interrupted runs failedImportLogs/GetImportRun/ListImportRunsRPCs (oneof sourcefor future providers); import dialog with progress polling in the logs tabworkspace add-log --gcp-projectwith--gcp-filter/--since/--limit, then the existing discovery flow