Document RI/SDI results in AFSC.search - #58
Merged
Conversation
search now walks the enlisted, officer, and RI/SDI tiers, so a single call can return a mix of Code classes -- the README only documented enlisted/officer results. Also fixes "Bomber pilot" -> "Bomber Pilot" to match the actual data and the rest of the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AFSC.searchwas expanded to also search the RI/SDI tier (Enlisted.search+Officer.search+RI.search), but the README's "Searching for Codes" section only documented enlisted/officer results -- it never mentioned a single call can return a mix ofEnlisted::Code,Officer::Code, andRI::Code.All new example output was run against the actual gem to confirm accuracy.