Adding "safe-guards" to avoid segfault in the GaussHitFinderSBN module#659
Draft
mattiasotgia wants to merge 3 commits into
Draft
Adding "safe-guards" to avoid segfault in the GaussHitFinderSBN module#659mattiasotgia wants to merge 3 commits into
mattiasotgia wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue
The introduction of the
NextADCThresholdparameter in LArSoft/larreco#92 highlighted some minor bugs in theGaussHitFinderSBNmodule that made the code segfault for some edge case.This PR aims at adding some safeguards to the code preventing the segfault to happen.
Description
The changes happens in three points of the code
peakFitterToolreturns the peak parameters for each "candidate hit". Here we added a check for all "not finite" bounds, whereas the old version of the code was only checking for the positive side. Since the