Skip to content

fix: Keyboard activation doesn't toggle Display menu controls#41089

Draft
juliajforesti wants to merge 5 commits into
developfrom
fix/display-menu-a11y
Draft

fix: Keyboard activation doesn't toggle Display menu controls#41089
juliajforesti wants to merge 5 commits into
developfrom
fix/display-menu-a11y

Conversation

@juliajforesti

@juliajforesti juliajforesti commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

CORE-2319

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Review in cubic

@changeset-bot

changeset-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ed193b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot

dionisio-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e572cd47-dd00-4fcd-a9f3-b76f69ace8d2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.13%. Comparing base (2c4292b) to head (ed193b7).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #41089      +/-   ##
===========================================
- Coverage    70.18%   70.13%   -0.06%     
===========================================
  Files         3368     3368              
  Lines       130022   130031       +9     
  Branches     22561    22567       +6     
===========================================
- Hits         91256    91191      -65     
- Misses       35446    35521      +75     
+ Partials      3320     3319       -1     
Flag Coverage Δ
e2e 59.30% <11.11%> (-0.08%) ⬇️
e2e-api 46.30% <ø> (-0.85%) ⬇️
unit 70.08% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliajforesti juliajforesti force-pushed the fix/display-menu-a11y branch from 3d6ee59 to 3d45f5b Compare June 26, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant