Repository navigation
Fix: Update process hanging in the web UI - #2163
Merged
Merged
Conversation
When started from the web UI, the installer ran inside the php-fpm service cgroup and was killed when the update restarted php-fpm, leaving the progress modal polling forever. The update request also held the PHP session lock for its full duration, blocking progress polling. - Relaunch web UI updates as a transient raspap-update systemd unit - Run the installer in the background and release the session lock in the update, log and version check endpoints - Report when the installer has stopped, ignore stale logs and only treat installer error lines as errors - Retry polling through web server restarts and handle failed version checks instead of spinning indefinitely - Add tests for log parsing and session locking Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When started from the web UI, the installer ran inside the php-fpm service cgroup and was killed when the update restarted php-fpm, leaving the progress modal polling forever. The update request also held the PHP session lock for its full duration, blocking progress polling.