Repository navigation
Check that the static driver can run standalone - #5465
Merged
Merged
Conversation
pfultz2
requested review from
VishalX,
anilmartha,
asparkhi,
sambanerxilinxamd and
sumitn-xilinx
as code owners
November 1, 2026 16:03
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The pipeline can falsely pass verification because it discards the driver’s exit status and misses dependency paths, allowing crashes, sanitizer failures, or non-standalone builds to go undetected.
2 open issues
What changed in this PR
This PR adds Jenkins coverage to check that MIGraphX’s static driver can run without shared libraries installed by rbuild or produced in the build tree.
Changes:
- Add an optional dependency check and enable it for the static build stage.
- Run driver verification after each CMake build and require a success message in its log.
| File | Description |
|---|---|
Jenkinsfile |
Adds standalone dependency checks and post-build driver verification. |
Review effort: Max
| # The driver must only need the ROCm and system shared libraries: nothing | ||
| # installed by rbuild and nothing from the build tree. | ||
| ldd ./bin/migraphx-driver | ||
| if ldd ./bin/migraphx-driver | grep -E "=> (/usr/local/lib/[^/]+|\$(pwd)/[^ ]+) "; then |
| if [ -n "\$(ls ./*.deb 2>/dev/null)" ]; then md5sum ./*.deb; fi | ||
| ${standalone_driver_check} | ||
| # The driver exits 0 even when verification fails, so check its log. | ||
| ./bin/migraphx-driver verify --test 2>&1 | tee driver.log |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5465 +/- ##
===========================================
- Coverage 92.95% 91.40% -1.55%
===========================================
Files 670 704 +34
Lines 40391 41488 +1097
===========================================
+ Hits 37542 37918 +376
- Misses 2849 3570 +721
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot ApplicableFollow the LLVM AI Tool Use Policy for contributions using AI.