Skip to content

chore: add security scanning workflows - #5299

Open
haribabug wants to merge 5 commits into
developfrom
add-security-scanning
Open

haribabug wants to merge 5 commits into
developfrom
add-security-scanning

Conversation

@haribabug

Copy link
Copy Markdown

Security Scanning Workflows Enablement

This PR adds standardized security scanning workflows and configurations from ROCm/rocm-repo-template.

Security Controls

  • PR Security Scan
  • Weekly Security Scan
  • Dependabot
  • CodeQL, Bandit, Gitleaks, Trivy, and Zizmor

Files added / updated

  • .github/workflows/pr-security-scan.yml — scans every pull request
  • .github/workflows/weekly-security-scan.yml — scheduled weekly scan
  • .github/dependabot.yml — automated dependency updates
  • .github/scan_tools_configs/bandit.yml — Python static analysis config
  • .github/scan_tools_configs/gitleaks.toml — secret detection config
  • .github/scan_tools_configs/trivy.yml — container/dependency vulnerability config
  • .github/scan_tools_configs/zizmor.yml — GitHub Actions security config

Why

This change aligns this repository with the ROCm GitHub Organization Security Baseline and enables consistent security controls across ROCm repositories.


For more details, refer ROCm GitHub Org Security Controls Baseline Architecture

Support/Questions: Teams Channel ROCm Security Discussions

Copies standardised security scanning config from
ROCm/rocm-repo-template.
@haribabug
haribabug requested a review from causten as a code owner September 22, 2026 18:08
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@causten

causten commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

@copilot add the test, examples, and tools folders to the skip-dirs section of .github/scan_tools_configs/bandit.yml and .github/scan_tools_configs/trivy.yml

Co-authored-by: causten <7440191+causten@users.noreply.github.com>

Copilot AI commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@copilot add the test, examples, and tools folders to the skip-dirs section of .github/scan_tools_configs/bandit.yml and .github/scan_tools_configs/trivy.yml

Implemented in c9d8498. Added test, examples, and tools to the skip directories in both .github/scan_tools_configs/bandit.yml and .github/scan_tools_configs/trivy.yml.

Syncs 7 security scanning file(s) with the latest version from
ROCm/rocm-repo-template.
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor
Security scan found no critical or high findings on lines changed by this pull request

View the security scan run for complete reports.

“New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta.

@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5299      +/-   ##
===========================================
- Coverage    93.13%   92.70%   -0.43%     
===========================================
  Files          625      638      +13     
  Lines        33252    37416    +4164     
===========================================
+ Hits         30967    34685    +3718     
- Misses        2285     2731     +446     

see 102 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Updates 8 security scanning file(s) to the latest version from
ROCm/rocm-repo-template.
Pins the 'ROCm/rocm-security-gh' security baseline from the floating
'v1' tag to v1.0.8 (35d3060c4b2ed48f950f85bd414a1302a431fc0b) and removes the zizmor
unpinned-uses allow list entry for it. 3 file(s) changed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants