Repository navigation
Feature/destinations polish - #142
Closed
bensoncappp wants to merge 26 commits into
Closed
bensoncappp wants to merge 26 commits into
bensoncappp wants to merge 26 commits into
Conversation
ci: set firebase project id and enable rules deploy workflow Security Scan fails on pre-existing vulnerabilities in the boilerplate's dependencies; fixed in a follow-up PR
fix(deps): patch high and critical audit findings
feat(destinations): add data model, security rules and schema docs Security Scan fails on newly published advisories in existing dependencies, unrelated to this change; addressed in the next hotfix PR.
fix(deps): patch new advisories and scope CI audit to production dependencies
feat(destinations): add idempotent seed script for sample destinations
feat(destinations): add destinations screen with accessibility feature filters
feat(destinations): save and remove destinations with transactional saveCount
feat(destinations): add shortlist screen with tags, tag filter and feature filter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ success: false }, so Save / Remove / tag buttons stayed on "Saving…" with no messagecallAction()(features/destinations/callAction.ts): wraps a Server Action call and turns a rejected request into{ success: false, error: 'Connection problem…' }Type of change
fix:)feat:)refactor:)docs:)chore:,build:,ci:)Test plan
pnpm run test): 3 new tests forcallAction(31 total)pnpm run typecheck)pnpm run lint){{placeholders}}(pnpm run validate)Firestore changes
firebase/firestore.rules)docs/FIRESTORE-SCHEMA.md)firebase/firestore.indexes.json)Environment variables
.env.examplefiles anddocs/ENV-VARS.md🤖 Generated with Claude Code