Skip to content

Feature/destinations polish - #142

Closed
bensoncappp wants to merge 26 commits into
RMIT-Garage:mainfrom
bensoncappp:feature/destinations-polish
Closed

bensoncappp wants to merge 26 commits into
RMIT-Garage:mainfrom
bensoncappp:feature/destinations-polish

Conversation

@bensoncappp

Copy link
Copy Markdown

Summary

  • Bug: if a Server Action request never reaches the server (e.g. offline), the call rejects instead of returning { success: false }, so Save / Remove / tag buttons stayed on "Saving…" with no message
  • Added callAction() (features/destinations/callAction.ts): wraps a Server Action call and turns a rejected request into { success: false, error: 'Connection problem…' }
  • Used for save and remove on Screen 1, and for tag updates and remove on Screen 2, so the user always gets a toast (1E / 2E) and the button resets (AC-10)

Type of change

  • Bug fix (fix:)
  • New feature (feat:)
  • Refactor (refactor:)
  • Documentation (docs:)
  • Infrastructure / CI (chore:, build:, ci:)

Test plan

  • Unit tests pass (pnpm run test): 3 new tests for callAction (31 total)
  • TypeScript check passes (pnpm run typecheck)
  • Lint passes (pnpm run lint)
  • Manual smoke test against a dev Firebase project: DevTools → Network → Offline → Save shows "Connection problem…" toast, button returns to Save, Firestore unchanged
  • No unreplaced {{placeholders}} (pnpm run validate)

Firestore changes

  • No Firestore changes
  • Security rules updated (firebase/firestore.rules)
  • Schema documented (docs/FIRESTORE-SCHEMA.md)
  • Indexes updated (firebase/firestore.indexes.json)

Environment variables

  • No new env vars
  • New vars added to .env.example files and docs/ENV-VARS.md

🤖 Generated with Claude Code

b-nson and others added 26 commits September 27, 2026 13:54
ci: set firebase project id and enable rules deploy workflow

Security Scan fails on pre-existing vulnerabilities in the boilerplate's dependencies; fixed in a follow-up PR
fix(deps): patch high and critical audit findings
feat(destinations): add data model, security rules and schema docs

Security Scan fails on newly published advisories in existing dependencies, unrelated to this change; addressed in the next hotfix PR.
fix(deps): patch new advisories and scope CI audit to production dependencies
feat(destinations): add idempotent seed script for sample destinations
feat(destinations): add destinations screen with accessibility feature filters
feat(destinations): save and remove destinations with transactional saveCount
feat(destinations): add shortlist screen with tags, tag filter and feature filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants