Skip to content

Inline syntaxpain#355

Merged
supersaiyansubtlety merged 51 commits into
QuiltMC:develop/2.8from
supersaiyansubtlety:inline-syntaxpain
Feb 7, 2026
Merged

Inline syntaxpain#355
supersaiyansubtlety merged 51 commits into
QuiltMC:develop/2.8from
supersaiyansubtlety:inline-syntaxpain

Conversation

@supersaiyansubtlety

@supersaiyansubtlety supersaiyansubtlety commented Dec 18, 2025

Copy link
Copy Markdown
Member

Caution

Do not squash merge

closes QuiltMC/syntaxpain#9


  • inlines https://github.com/QuiltMC/syntaxpain with includeBuild in syntaxpain/; git history is maintained
  • replaces the org.xbib.gradle.plugin.jflex plugin with a jflex.anttask.JFlexTask in build script; the plugin used deprecated gradle features, so the build workflow's --warning-mode fail would cause it to fail

once this is merged we should:

eristhea and others added 30 commits October 1, 2023 21:17
disable automatic QuickFindDialog creation when SyntaxpainConfiguration has null dialog factory
…s may implement their own translation

inline initComponents because re-calling it or overriding it and trying to access instance fields could lead to unexpected behavior; users should put the contents of their overrides in their constructors
add QuickFindToolBar::dismissOnFocusLost, allowing subclasses to control whether the toolbar is dismissed when it loses focus
remove escape-to-close keybind from QuickFindToolBar; users may add their own keybinds
put installation side effects in static install methods
put the rest of installation in constructors
…n via JavaSyntaxKit::setSyntaxColors

remove unused rightMargin code from SyntaxView
@supersaiyansubtlety supersaiyansubtlety self-assigned this Dec 18, 2025
@supersaiyansubtlety supersaiyansubtlety added enhancement new feature or request user interface affects the enigma ui refactor improvements that don't impact functionality labels Dec 18, 2025
@supersaiyansubtlety

Copy link
Copy Markdown
Member Author

once this is merged we should transfer #359 and archive https://github.com/QuiltMC/syntaxpain

@eristhea eristhea self-requested a review January 16, 2026 17:04

@eristhea eristhea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! i skimmed through the syntaxpain code and. wow. why does every file have its own comment and code style

@supersaiyansubtlety supersaiyansubtlety merged commit 2bb4c7c into QuiltMC:develop/2.8 Feb 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement new feature or request refactor improvements that don't impact functionality user interface affects the enigma ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants