Inline syntaxpain#355
Merged
supersaiyansubtlety merged 51 commits intoFeb 7, 2026
Merged
Conversation
fixes line number resizing issues
Fix quick find dialog issues
disable automatic QuickFindDialog creation when SyntaxpainConfiguration has null dialog factory
…s may implement their own translation inline initComponents because re-calling it or overriding it and trying to access instance fields could lead to unexpected behavior; users should put the contents of their overrides in their constructors add QuickFindToolBar::dismissOnFocusLost, allowing subclasses to control whether the toolbar is dismissed when it loses focus remove escape-to-close keybind from QuickFindToolBar; users may add their own keybinds
…-bar Quick find tool bar
…l installation remove QuickFindDialog
put installation side effects in static install methods put the rest of installation in constructors
…n via JavaSyntaxKit::setSyntaxColors remove unused rightMargin code from SyntaxView
update org.xbib.gradle.plugin.jflex to 3.0.2 --warning-mode fail causes failure due to org.xbib.gradle.plugin.jflex
…ask in build script
Member
Author
|
once this is merged we should transfer #359 and archive https://github.com/QuiltMC/syntaxpain |
eristhea
approved these changes
Feb 6, 2026
eristhea
left a comment
Member
There was a problem hiding this comment.
looks great! i skimmed through the syntaxpain code and. wow. why does every file have its own comment and code style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Do not squash merge
closes QuiltMC/syntaxpain#9
includeBuildinsyntaxpain/; git history is maintainedorg.xbib.gradle.plugin.jflexplugin with ajflex.anttask.JFlexTaskin build script; the plugin used deprecated gradle features, so the build workflow's--warning-mode failwould cause it to failonce this is merged we should: