Skip to content

fix: restore add split button in advanced custom routes - #7289

Merged
seefs001 merged 1 commit into
QuantumNous:mainfrom
seefs001:fix/advanced-custom-editor-add-sub-route
Sep 9, 2026
Merged

fix: restore add split button in advanced custom routes#7289
seefs001 merged 1 commit into
QuantumNous:mainfrom
seefs001:fix/advanced-custom-editor-add-sub-route

Conversation

@seefs001

@seefs001 seefs001 commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

⚠️ 提交说明 / PR Notice

English template: .github/PULL_REQUEST_TEMPLATE/en.md

Important

  • 描述可用 AI 辅助。提交前请审阅全文,并声明对其负责,避免未经核对的直接粘贴。
  • 请按本模板填写后再提交。

🔗 关联任务 / Related Issue

  • 新功能请填写下方 Issue 编号;若还没有对应 Issue,请先自行创建。功能讨论请放在 Issue 中进行。

  • 改动较大或方向性变更,请先在关联 Issue 中与维护者达成一致,再提交 PR。

  • Bug 修复请关联对应 Issue。设计取舍、理解偏差或预期不一致,更适合作为讨论或功能请求。

  • Closes “高级自定义”渠道配置路由内的”添加分流“按钮不见了 #7286

🚀 变更类型 / Type of change

  • 🐛 Bug 修复 (Bug fix)
  • ✨ 新功能 (New feature)
  • ⚡ 性能优化 / 重构 (Refactor)
  • 📝 文档更新 (Documentation)

📝 变更描述 / Description

(简述做了什么、为什么生效。如果难以简述,建议先拆分范围,或在 Issue 中与维护者对齐。)

修复被错误隐藏的内容

📸 运行证明 / Proof of Work

(请写明如何验证:实际步骤与观察结果。UI 变更请附截图或录屏;Bug 修复请说明复现过程与修复后结果。)

✅ 提交前检查项 / Checklist

  • 人工确认: 无论描述是否由 AI 生成,我已审阅全部内容,并声明对其准确性与完整性负责。
  • 非重复提交: 我已搜索现有的 IssuesPRs,确认不是重复提交。
  • 新功能关联 Issue: 若此 PR 标记为 New feature,我已关联对应 Issue;若尚无 Issue,我已先自行创建。
  • 事前沟通: 若改动较大或涉及方向性变更,已在关联 Issue 中与维护者沟通并达成一致。
  • 功能范围: 本 PR 不是 Coding Plan、逆向渠道、第三方封装接口,也不是对 Codex 渠道类型的改动。
  • 范围聚焦: 本 PR 为一项聚焦改动,未包含无关代码。
  • 本地验证: 已在本地运行并通过测试或手动验证,维护者可以据此复核。
  • 安全合规: 代码中无敏感凭据,且符合项目代码规范。

Summary by CodeRabbit

  • Accessibility

    • Improved screen-reader handling for the “Add split” button icon.
  • UI Improvements

    • Moved the “Add split” control and explanatory text into the route group body for clearer layout and interaction.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f67a2470-d2b2-4d60-b286-cc7a734c71f9

📥 Commits

Reviewing files that changed from the base of the PR and between 064ed94 and 78c1fb2.

📒 Files selected for processing (1)
  • web/src/features/channels/components/dialogs/advanced-custom-editor-dialog.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The route group editor now renders the explanatory text and “Add split” button in the group body. The header conditional closes before the body, and the Plus icon is marked as decorative.

Changes

Route group editor

Layer / File(s) Summary
Move split controls into the group body
web/src/features/channels/components/dialogs/advanced-custom-editor-dialog.tsx
The explanatory text and “Add split” button now render below the optional header. The body receives a top border when the header is shown. The Plus icon has aria-hidden="true".

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 78c1f

Advanced Custom route configuration again displays the Add split control, allowing users to add route splits as intended. No current merge-blocking risk is identified.

Suggested reviewers: calcium-ion

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes restoring the missing Add Split button in Advanced Custom routes.
Linked Issues check ✅ Passed The change restores the Add Split button for Advanced Custom route configuration, which directly satisfies issue #7286.
Out of Scope Changes check ✅ Passed The changes are limited to the affected route editor UI. Moving the button and explanatory text into the group body, plus marking the decorative icon as hidden, supports the stated fix.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit hops where split paths grow
The button returns below the row
The header rests, the body shines
A hidden plus keeps markup fine
Soft paws applaud the cleaner flow

Comment @coderabbitai help to get the list of available commands.

@seefs001
seefs001 merged commit bdef117 into QuantumNous:main Sep 9, 2026
2 of 3 checks passed
TanTaolov added a commit to TanTaolov/new-api that referenced this pull request Sep 10, 2026
- 064ed94 feat(billing): 支持按请求固定的表达式计价
- 7cf9b47 fix(web): 保持模型定价内容在单一滚动区域内
- a205741 fix(alibaba): 修正 Wan 模型协议与用量统计
- 12be997 fix(web): 统一服务端错误通知
- d52bdc0 feat(billing): 新增基于时间的定价编辑器与表达式预览
- 876903a fix: 修正火山方舟渠道获取模型列表的端点路径 (QuantumNous#7203)
- c79b74b fix(frontend): 去重 /api/status 请求 (QuantumNous#7189)
- 4fc9d1f fix(options): 重建 options 表主键,防止定价写入重置已有行
- 9bf328d fix: 在 Sora 视频查询中保留 provider 字段
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

“高级自定义”渠道配置路由内的”添加分流“按钮不见了

1 participant