Validate Jobflow workflow outputs - #3405
Open
Andrew-S-Rosen wants to merge 26 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3405 +/- ##
=======================================
Coverage 99.48% 99.48%
=======================================
Files 99 99
Lines 4258 4258
=======================================
Hits 4236 4236
Misses 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This reverts commit 4c58eb5.
Andrew-S-Rosen
commented
Aug 10, 2026
Member
Author
There was a problem hiding this comment.
@vineetbansal ChatGPT had to make several changes to the source code. I imagine this may not be necessary and that there is some simpler change we can be making upstream in jobflow to avoid this.
2 tasks
Andrew-S-Rosen
marked this pull request as ready for review
August 11, 2026 14:36
…low-results # Conflicts: # tests/jobflow/test_syntax.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/jobflowexecution inspect a concrete returned result..outputcomposition from quacc-decorated Jobflow workflows.@jf.job.copy_filesdirectory references.JobflowCopycompatibility wrapper after merging currentmain.Why
ensure_success=Trueonly confirms that Jobflow did not mark execution as failed. It does not prove that the expected value was returned or that downstream jobs received usable outputs. Quacc workflows also need to remain workflow-engine agnostic rather than requiring Jobflow-specific.outputaccess.PR #3409 replaced custom copy wrappers with ordinary list-of-dictionary transfer specifications. Keeping the old Jobflow wrapper after merging that PR caused an import from the deleted
job_argument.pymodule, so this branch now relies entirely on Jobflow's normal argument traversal.Validation
jf.run_locallycalls intests/jobflowcapture and inspect responses.outputcalls insrc/quacc/recipes