Skip to content

feat: compose Q10 map content from grouped traits#886

Closed
tubededentifrice wants to merge 11 commits into
Python-roborock:mainfrom
tubededentifrice:agent/q10-map-traits
Closed

feat: compose Q10 map content from grouped traits#886
tubededentifrice wants to merge 11 commits into
Python-roborock:mainfrom
tubededentifrice:agent/q10-map-traits

Conversation

@tubededentifrice

Copy link
Copy Markdown
Contributor

Summary

Completes the Q10 map integration on top of #885 with a small low-level/high-level trait boundary matching the three incoming data streams.

  • MapDpsTrait owns the restricted-zone and virtual-wall DPS values and exposes their decoded overlays.
  • MapContentTrait retains the latest map and trace packets and calls the pure render_q10_map function whenever map, trace, or overlay data changes.
  • The high-level trait exposes only caller-facing map data: the composed image, rooms, path, robot position, and heading.
  • Calibration, layers, projected map data, and other rendering intermediates stay inside the renderer.
  • Q10PropertiesApi wires the DPS trait into both DPS fanout and the dependent map-content trait.

This also removes the stacked path-specific CLI command, since the normal image_content is already the single composed output.

Validation

  • pre-commit run --show-diff-on-failure --color=always --all-files
  • pytest -q — 797 passed, 86 snapshots passed

Stack

@tubededentifrice

Copy link
Copy Markdown
Contributor Author

Superseded by #887. This replacement uses the identical tested three-file tree on a fresh branch from merged , avoiding both the inherited stacked commit-message failure and any force-push/history rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant