Skip to content

refactor(map): address Q10 decoding review feedback#884

Merged
allenporter merged 1 commit into
Python-roborock:mainfrom
tubededentifrice:agent/q10-map-review-cleanups
Jul 19, 2026
Merged

refactor(map): address Q10 decoding review feedback#884
allenporter merged 1 commit into
Python-roborock:mainfrom
tubededentifrice:agent/q10-map-review-cleanups

Conversation

@tubededentifrice

Copy link
Copy Markdown
Contributor

Follow-up to #881 addressing the review feedback left just after it merged.

  • use the DPS-native base64 str | None boundary for Q10 zone and virtual-wall blobs, keeping decoded bytes internal
  • replace the compact calibration classification expression and magic numbers with a named enum and an explicit row-major classification pass
  • expose Q10 grid decomposition as Q10MapPacket.layers
  • move Q10 classifier/layer tests into test_b01_q10_map_parser.py

Validation:

  • pre-commit run --show-diff-on-failure --color=always --all-files
  • pytest -q (782 passed, 86 snapshots passed)

@allenporter
allenporter merged commit 6e5bf5b into Python-roborock:main Jul 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants