feat: add photo for obstacle avoidance#880
Conversation
allenporter
left a comment
allenporter
left a comment
There was a problem hiding this comment.
Very cool, high level i have one starting comment about protocol layering. The idea behind some of these layers was to not have to pass security data everywhere.
| public_key = await self._standard_rpc_channel.send_command(RoborockCommand.GET_RANDOM_PKEY) | ||
| if not isinstance(public_key, dict) or not isinstance(public_key.get("pub_key"), dict): | ||
| raise RoborockException("get_random_pkey response did not contain a public key") | ||
| security = self._security_data.to_dict()["security"] |
There was a problem hiding this comment.
Can we put this behind the blob rpc channel?
That is, it can handle wrapping the payload adding necessary lower level security information given a higher level command + params. Or there can be two things, a blob channel and a blob rpc channel, if you want to keep the internal layers separate.
| return bool((response[0] >> _MAP_OBJECT_PHOTO_ENABLED_BIT) & 1) | ||
|
|
||
| async def get_photo(self, photo_id: str, photo_type: int = _PHOTO_TYPE_SMALL) -> ObstaclePhoto: | ||
| """Fetch an obstacle photo by its map photo id.""" |
There was a problem hiding this comment.
can you include details in the get photo pydoc about how you obtain these photo ids or photo types? (should photo type be an enum, or not exposed at all?)
| raise RoborockException("Invalid V1 blob response format") | ||
| try: | ||
| data = Utils.decompress(payload[header_size:end_offset]) | ||
| except Exception as err: |
There was a problem hiding this comment.
i think we can probably make this more narrow to just exceptions that we're expecting here
This is kind of a fun one, it will show the photos from the vacuum when it sees obstacles (if the vac supports it).
Let me know if you want me to split it up into a few different smaller PRs there are a couple of quick and easy PRs i can break out if you'd like
HA will have to call this and cache images appropriately and gate on features.