fix: Correct reset consumable parameters for strainer and cleaning brush#879
Merged
allenporter merged 1 commit intoJul 18, 2026
Merged
Conversation
allenporter
marked this pull request as ready for review
July 18, 2026 14:11
Lash-L
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vacuum firmware expects the parameter in the
reset_consumablecommand to match the internal property keys exactly. For the dock strainer and cleaning brush, these keys are plural:strainer_work_timescleaning_brush_work_timesCurrently,
ConsumableAttributedefines them as singular (strainer_work_timeandcleaning_brush_work_time). Because of this, the library sends singular parameters when resetting them, which the vacuum firmware silently ignores.This PR:
ConsumableAttribute.STRAINER_WORK_TIMEandConsumableAttribute.CLEANING_BRUSH_WORK_TIMEto their correct plural forms (strainer_work_timesandcleaning_brush_work_times).Fixes Home Assistant Core Issue: home-assistant/core#175672