Skip to content

fix: Correct reset consumable parameters for strainer and cleaning brush#879

Merged
allenporter merged 1 commit into
Python-roborock:mainfrom
allenporter:fix-ha-issue-175672
Jul 18, 2026
Merged

fix: Correct reset consumable parameters for strainer and cleaning brush#879
allenporter merged 1 commit into
Python-roborock:mainfrom
allenporter:fix-ha-issue-175672

Conversation

@allenporter

Copy link
Copy Markdown
Contributor

The vacuum firmware expects the parameter in the reset_consumable command to match the internal property keys exactly. For the dock strainer and cleaning brush, these keys are plural:

  • strainer_work_times
  • cleaning_brush_work_times

Currently, ConsumableAttribute defines them as singular (strainer_work_time and cleaning_brush_work_time). Because of this, the library sends singular parameters when resetting them, which the vacuum firmware silently ignores.

This PR:

  1. Updates the values of ConsumableAttribute.STRAINER_WORK_TIME and ConsumableAttribute.CLEANING_BRUSH_WORK_TIME to their correct plural forms (strainer_work_times and cleaning_brush_work_times).
  2. Corrects the unit tests and integration/simulator tests to expect and verify the correct plural parameters.

Fixes Home Assistant Core Issue: home-assistant/core#175672

@allenporter
allenporter marked this pull request as ready for review July 18, 2026 14:11
@allenporter
allenporter merged commit b11fc49 into Python-roborock:main Jul 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants