fix: clear stale nmmo3 entity observations - #634
Open
jokrasno wants to merge 1 commit into
Open
Conversation
jokrasno
force-pushed
the
fix/nmmo3-stale-entity-observations
branch
from
August 16, 2026 21:39
eee0de3 to
783d5a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pidscell is emptyEntitybetween cells and exercises the productionallocate_mmo()/compute_all_obs()pathFixes #629.
Verification
On pristine
4.0(c5d3c637), the regression failed after the entity moved:The identically rebuilt test exits 0 after this change. It uses the real
MMOandEntitystructures and statically checks the 1,707-byte observation layout; no encoder logic is copied into the test.Additional checks:
nmmo3.cdesktop build: passedpython -m compileall -q pufferlib: passedpytest tests/test_import_performance.py -q: 1 passedgit diff --check: passedCompatibility note
This intentionally changes empty-cell observations from stale last-seen entity data to truthful snapshot semantics. As discussed in #629, existing weights may have learned to use the residue as an implicit memory channel. This PR keeps the correctness fix narrow; if compatibility needs an opt-in flag or environment-version boundary, I am happy to adapt it to the maintainers' preferred policy.
The native harness follows the repository's documented-command convention but is not currently discovered by existing CI. Wiring it into CI remains a maintainer integration decision.