Fix a typo and two copy-pasted docstrings in the telemetry module - #80
Avicennasis wants to merge 1 commit into
Conversation
- telemetry/core/service.py: 'Supress' -> 'Suppress' - telemetry/interactive/prompts/identity.py: two docstrings copied from newsletter.py now describe the identity prompt Comments and docstrings only; no functional changes. Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
anuragg1209
left a comment
There was a problem hiding this comment.
Can you please fix the failing Ruff test case? Thanks!
|
Hi @anuragg1209 — happy to help, but I think this one isn't coming from my change, and I'd rather flag that than quietly expand the PR. This PR changes 3 lines of comment/docstring text in 2 files. I checked out clean Delta from this PR: 0. None of the reported errors are on lines the PR touches — the CI log points at The cause looks like an unpinned lint dependency rather than anything in the diff. "ruff>=0.11.6",and Two ways I can help, whichever you prefer:
I'd suggest keeping either of those out of this PR so the typo fix stays reviewable — but if you'd rather I just fold the lint fixes in here, say the word and I'll do that instead. |
Summary
Three comment/docstring fixes, no functional changes.
# Supress warnings-># Suppress warnings(the block comment two lines above already spells it "Suppress")._should_prompt): "Check if the user should be prompted tosubscribe to the newsletter." -> "...toshare anonymous usage analytics." The line is copied fromnewsletter.py; this module is the identity/analytics prompt (kind="identity", title "Share anonymous usage analytics?")._on_done): "Done callback fornewsletterprompt." -> "Done callback foridentityprompt."The matching lines in
prompts/newsletter.pyare correct there and were left untouched. Comments and docstrings only -ruff/pyrightbehaviour is unaffected.