Validate upload caps and defer subsampled contexts to the server - #396
Merged
Merged
Conversation
|
|
ggprior
previously approved these changes
Sep 22, 2026
ggprior
left a comment
Contributor
There was a problem hiding this comment.
Let's check if we can avoid the duplication. tabpfn-common-utils or server-side validation?
Otherwise LGTM pending this double check.
simo-prior
reviewed
Sep 23, 2026
simo-prior
reviewed
Sep 23, 2026
simo-prior
reviewed
Sep 23, 2026
simo-prior
reviewed
Sep 23, 2026
simo-prior
reviewed
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by Codex
Validate training uploads against the upload cap returned by the server so valid subsampled uploads are not rejected against the per-estimator cap. Keep static shape and output checks in the client, and defer subsampled context validation and context-dependent prediction limits to the server. This avoids duplicating TabPFN's subsampling rules in the client; context errors can be reported after upload.
Validation: 20 validation, estimator, and group-column tests passed. The full configured Trunk gate passed across 57 files.