Skip to content

Validate upload caps and defer subsampled contexts to the server - #396

Merged
adrian-prior merged 4 commits into
mainfrom
adrian/subsampled-upload-validation
Sep 23, 2026
Merged

adrian-prior merged 4 commits into
mainfrom
adrian/subsampled-upload-validation

Conversation

@adrian-prior

@adrian-prior adrian-prior commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Generated by Codex

Validate training uploads against the upload cap returned by the server so valid subsampled uploads are not rejected against the per-estimator cap. Keep static shape and output checks in the client, and defer subsampled context validation and context-dependent prediction limits to the server. This avoids duplicating TabPFN's subsampling rules in the client; context errors can be reported after upload.

Validation: 20 validation, estimator, and group-column tests passed. The full configured Trunk gate passed across 57 files.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@adrian-prior
adrian-prior marked this pull request as ready for review September 22, 2026 07:26
@adrian-prior
adrian-prior requested a review from a team as a code owner September 22, 2026 07:26
ggprior
ggprior previously approved these changes Sep 22, 2026

@ggprior ggprior left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check if we can avoid the duplication. tabpfn-common-utils or server-side validation?
Otherwise LGTM pending this double check.

Comment thread src/tabpfn_client/estimator.py Outdated
@adrian-prior adrian-prior changed the title Validate subsampled uploads separately from estimator contexts Validate upload caps and defer subsampled contexts to the server Sep 22, 2026
Comment thread src/tabpfn_client/api_models.py Outdated
Comment thread src/tabpfn_client/estimator.py Outdated
Comment thread src/tabpfn_client/estimator.py Outdated
Comment thread src/tabpfn_client/estimator.py Outdated
Comment thread src/tabpfn_client/estimator.py Outdated

@simo-prior simo-prior left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@simo-prior simo-prior left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adrian-prior
adrian-prior added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit 8555200 Sep 23, 2026
10 of 11 checks passed
@adrian-prior
adrian-prior deleted the adrian/subsampled-upload-validation branch September 23, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants