Fix: pin breathe to <5 due to potential name conflicts - #1615
Merged
Merged
Conversation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
figueroa1395
approved these changes
Sep 30, 2026
figueroa1395
left a comment
Member
There was a problem hiding this comment.
Docs build successfully now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The C API docs have been broken since v1.13.179 (#1612) because Breathe had a major version bump that seems to be incompatible with our setup.
The docs build will raise a warning (we don't have warnings-as-errors enabled yet in our readthedocs build) and the docs will have the following warning
This seems to be caused by the fact that breathe 5 uses the Doxygen-generated shortname, which is the shortest unique name that matches a file. For files with a unique name (e.g.,
basics.h), that is simply the file name.However, this is not future compatible, as adding a new file with the same name in another directory will cause the Doxygen-generated shortname to change to a path, e.g.
power_grid_model_c/basics.hadfoo/basics.h, effectively breaking the internal linkage if we depend purely on the short namebasics.h. Therefore, the docs will not be stable under addition of new files, which is bound to happen..hending is most likely restricted to just the C API headers)model.hpp).Related
Underlying issue reported to Breathe in breathe-doc/breathe#1084