Enable SSL certificate verification for PlayFab API requests#200
Open
rgomez391 wants to merge 1 commit into
Open
Enable SSL certificate verification for PlayFab API requests#200rgomez391 wants to merge 1 commit into
rgomez391 wants to merge 1 commit into
Conversation
CURLOPT_SSL_VERIFYPEER was set to false, disabling TLS certificate verification for all PlayFab API requests and exposing the secret API key and traffic to man-in-the-middle attacks. Set it to true to match the upstream XPlatCppSdk fix. Resolves AB#62661974.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables TLS certificate verification for all PlayFab API requests in the C++ GSDK.
Previously, CURLOPT_SSL_VERIFYPEER was set to
falseinPlayFabHttp.cpp, disabling SSL certificate verification for every PlayFab API call. This exposed the developer's secret API key and all API traffic to man-in-the-middle (MITM) interception. The disabling was a temporary workaround (// TODO: Replace this with a ca-bundle ref???) that was never resolved.Fix
Set
CURLOPT_SSL_VERIFYPEERtotrue, matching the resolution already shipped in the sibling SDKPlayFab/XPlatCppSdk.CURLOPT_SSL_VERIFYHOSTremains at its secure default (2).Testing
Notes
Resolves AB#62661974