Repository navigation
Fix unauthenticated xparl control deserialization - #1176
Merged
Merged
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xparl's master accepted network-supplied cloudpickle metadata without authentication. This change removes executable deserialization from control/status messages and requires CURVE authentication and encryption on every xparl ZeroMQ connection, including worker/job execution sockets. The server verifies the client key against the cluster secret; no unauthenticated fallback is provided.
Control metadata now uses a data-only JSON codec with explicit record types, field/type checks, size/depth limits, and malformed-message rejection that preserves the master's REP request/reply cycle. HTTP monitor/log endpoints require credentials, and the master/HTTP listeners default to loopback. The security guide documents private-network operation and coordinated upgrades.
Validation:
add(2, 3) == 5.git diff --check.Migration: configure a fresh shared
XPARL_AUTH_TOKENof at least 32 bytes on every node/client and restart them together. The new JSON/CURVE protocol is incompatible with older processes. Published historical packages require an explicit upgrade; merging source does not update existing installations. Trusted cluster members retain the intended ability to execute Python code, and heartbeat/HTTP access still requires network isolation (SSH tunnel or HTTPS for remote HTTP).