Repository navigation
feat: integrate CodeBuddy Code foreground TUI sessions - #8202
milesatao-svg wants to merge 41 commits into
Conversation
Preserve harness-owned evidence and merge current canonical API, storage, and native Chat updates. Runtime proof remains qualified by its original source.
Build the real daemon in PR CI for isolated VPS runtime verification without local validation suites or dependency installations. Record source revision, Go build info, and executable hash.
# Conflicts: # backend/internal/adapters/agent/registry/registry_test.go # backend/internal/cli/spawn.go # backend/internal/domain/harness.go # backend/internal/httpd/apispec/openapi.yaml # backend/internal/httpd/controllers/dto.go # backend/internal/observe/activity/observer.go # backend/internal/service/agentauth/plans_test.go # backend/internal/service/systeminstall/systeminstall.go # backend/internal/storage/sqlite/db.go # frontend/src/api/schema.ts # frontend/src/docs/content/plugins/agents/index.mdx # packages/product-ui/src/agents.ts
# Conflicts: # backend/internal/storage/sqlite/migrate_burned_versions_test.go
# Conflicts: # backend/internal/storage/sqlite/db.go # backend/internal/storage/sqlite/migrate_burned_versions_test.go # backend/internal/storage/sqlite/migrate_codebuddy_test.go # backend/internal/storage/sqlite/migrations/0207_allow_codebuddy_harness.sql # backend/internal/storage/sqlite/migrations/0214_allow_codebuddy_harness.sql # backend/internal/storage/sqlite/migrations/0215_allow_codebuddy_harness.sql
…work/acp-batch-codebuddy-20261018
…work/acp-batch-codebuddy-20261018
…pr6546-login-models
Copied source evidence 1/2Historical material from original PR #6546, copied for this account migration. Source PR head when copied: Original comment by @nikhilachale on 2026-10-11T15:33:05ZCodeBuddy TUI qualification evidence is published immutably at Final daemon/UI/source5827f13d75b639eac6ed76f6d572b6752c060da5:23 green exact-head checks. Earlier native/login/provider/startup/CI/static-renderer/capture failures remain separate. TUI/default permissions only; configured auth/freeform models remain honest. Owned cleanup confirmed; no merge/release/deploy. Original comment by @nikhilachale on 2026-10-11T15:47:28ZFinal handoff: source Original comment by @nikhilachale on 2026-10-12T16:50:35ZHarness-specific reports, JSON receipts, screenshots and provenance now live on this integration PR branch, rather than the skill PR #6509. Evidence index with embedded screenshots and JSON links. Historical successes, failures and scope limitations remain as recorded. Moving these files does not rerun native/AO testing or upgrade any verdict. This is evidence relocation only. Existing tested source/native hashes and failures are preserved; the documentation commit is not a fresh runtime pass. Applicable checks run in PR CI. Original comment by @nikhilachale on 2026-10-12T18:08:32ZCanonical main conflicts reconciled at Validation is PR CI only; current-head checks are pending until GitHub reports them. This merge does not constitute a new native/AO run or promote historical fresh/restore/provider-role proof. Harness evidence stays on this integration PR; PR6509 remains reusable guidance and linked summaries. Original comment by @nikhilachale on 2026-10-12T18:17:54ZCanonical main conflicts reconciled at Validation is PR CI only; current-head checks are pending until GitHub reports them. This merge does not constitute a new native/AO run or promote historical fresh/restore/provider-role proof. Harness evidence stays on this integration PR; PR6509 remains reusable guidance and linked summaries. Original comment by @nikhilachale on 2026-10-12T19:49:35ZCanonical main conflicts reconciled at Validation is PR CI only; current-head checks are pending until GitHub reports them. This merge does not constitute a new native/AO run or promote historical fresh/restore/provider-role proof. Harness evidence stays on this integration PR; PR6509 remains reusable guidance and linked summaries. Original comment by @nikhilachale on 2026-10-12T20:59:25ZCanonical main conflicts reconciled at Validation is PR CI only; current-head checks are pending until GitHub reports them. This merge does not constitute a new native/AO run or promote historical fresh/restore/provider-role proof. Harness evidence stays on this integration PR; PR6509 remains reusable guidance and linked summaries. Original comment by @nikhilachale on 2026-10-18T17:20:35ZContinuing existing PR #6546 on the authorized VPS. Refreshed actual live head Plan: (1) qualify installed official 2.164.0 stdio ACP in isolated runtime/profile, including exact load and additive instructions; (2) only after native prerequisites pass, add a thin provider binding around shared nativeacp/persistenthost with meaningful regression coverage, conservative settings, no handoff/reviewer changes; (3) qualify real provider lifecycle and actual AO Chat UI, with direct authorized GitHub screenshot attachments; (4) refresh both remotes before each push/status, inspect exact-head CI and independent review. Routine suites run in PR CI only. No new evidence/report files in Git and no changes/comments to #6509. Initial resource preflight: ~508 MiB free disk, ~2.5 GiB available memory. Prefer existing pinned binaries/CI artifacts; avoid a dependency installation that exceeds capacity. Native/UI/approval/interrupt/restore gates are NOT_RUN at this point; help/version output is discovery only. Private runtime bytes stay under the supplied runtime root. Unsupported or unqualified Chat remains unregistered. Original comment by @nikhilachale on 2026-10-18T17:24:05ZBLOCKED — native ACP account-session authorization unavailable. Not READY_FROM_OUR_SIDE. Refreshed BOTH actual PR branch and canonical main immediately before this report: head Actual native probe and retained first failuresVPS official installed
Acceptance status
Exact-head CI links
Disposition and cleanupNo build, routine suite, lint, vet, typecheck, fixtures or workflow emulation run on VPS. No AO daemon, Electron instance or AO session launched. Bounded native children stopped; private isolated runtime/profile bytes retained under the supplied owned scratch runtime, no deliverable evidence files added to Git. Production and unrelated controls untouched. Native CLI/source hashes are above; AO binary/UI build/model/session/generation fingerprints are unavailable, because AO Chat qualification never started. No screenshots captured or uploaded. First native failure and both unsuccessful recovery attempts are retained inline above. Required external prerequisite: an already authorized, valid CodeBuddy native account session usable by ACP, or an officially supported release/path that admits the authorized custom-provider configuration without that account prerequisite. Then rerun the full native/AO/UI lifecycle gates. A legitimate direct GitHub screenshot attachment mechanism is also required for final handoff. No merge, release or deployment performed. The queue moving on does not resolve this blocker. Original comment by @nikhilachale on 2026-10-18T21:43:35ZReconciliation pass only on the authorized VPS. Refreshed live PR head Original comment by @nikhilachale on 2026-10-18T21:44:17ZRECONCILED — reconciliation pass only; ACP readiness not claimed. Pushed Conflict decisions: combined the migration ledger instead of selecting either side. Main's merged 210–212 migrations are unchanged. Moved pending CodeBuddy migration 207 to 214 above current main (213 has an observed open competing claim), updated executable test/comment references, and retained 207 as burned for preview databases. Existing repair coverage still seeds preview 207. Historical evidence, first failures, contributor TUI work, native defaults, and Chat registration remain unchanged. No ACP implementation in this pass; prior account-session/UI blockers remain historical unresolved qualification gaps, not reconciliation blockers. Recheck migration allocation before eventual merge.
Cleanup: parent already removed only verified unused ignored historical node_modules, disposable npm cache, and two superseded vendor versions, checking affected Git status and lockfile hashes unchanged. This pass deleted no additional data; approximately 2.8 GiB free at preflight. No source/history/credentials/screenshots/evidence removed, no audit processes launched, no production state touched. No new report/evidence files committed, no action on PR6509, no merge/release/deployment. Full current-head CI and ACP acceptance will be revisited in the ACP pass. Original comment by @nikhilachale on 2026-10-18T22:34:03ZContinuing ACP implementation on refreshed live head Implementation plan: add Retain first native authentication-required failures from the prior final comment; no login retry/key substitution. Current disk ~1.1 GiB; no further cleanup, dependency installs or expensive build planned. Missing authenticated new/load blocks real Chat lifecycle, private instruction consumption and correlated AO UI proof, but does not stop this source work. Screenshot direct attachment remains unqualified. No modifications/comments to #6509; no merge/release/deploy. Original comment by @nikhilachale on 2026-10-18T22:37:43ZBLOCKED — gated candidate implemented; not READY_FROM_OUR_SIDE. Final refresh of both actual branches: pushed/live head Source progress and reviewAdded Chat remains unregistered in the shipped driver registry. Meaningful authored CI regressions cover additive/default prompt arguments, instruction UTF-8/NUL/64KiB bounds, settings rejection, exact version admission and shipped-registry exclusion. No runtime/fixture suites, lint, vet, typecheck or workflow emulation ran locally. Independent read-only reviewer examined the candidate and shared seams: no remaining actionable findings after strict raw permission admission replaced normalization (which would accept unknown values as default). Review was source-only; no compile/native/UI qualification. This is independent candidate review, not final full integration approval. Native fingerprints and retained first failuresActual installed executable
Shipped source contains the additive argument and native foreground environment controls. This does not prove provider consumption. Retained original native ACP/auth failures remain authoritative as originally recorded. Native initialize advertised v1/loadSession; real session/new and explicit load returned authentication-required before admission across the prior bounded isolated-profile attempts. No blind authentication retry, key substitution or private vendor patch in this continuation. Account configuration is not authorization. No stable authenticated native session/model/AO generation exists for this candidate; provider wire role remains unknown. Acceptance
Exact-head CI inspected at 2026-10-18T22:37:42.528646+00:00
No completed failure logs exist for these unfinished workflows at inspection. CI is not claimed green; Go is pending admission/queue, other workflows queued/in progress. Required current-head results still need follow-up before readiness. Cleanup and remaining actionNo owned daemon, Electron app, audit session or provider turn was started in this continuation; bounded version command exited. No production restart/profile/tunnel/token change. No additional disk deletion; ~1.1GiB free. Parent cleanup removed only verified unused ignored historical dependencies/rebuildable cache/superseded vendor copies and checked source status/lockfile hashes unchanged; source/history/credentials/evidence were preserved. New detailed receipts exist only inline here; no report/JSON/PNG evidence committed. #6509 received zero modifications/comments. No merge/release/deploy. Remaining external prerequisite: a valid CodeBuddy native account session using the authorized account, then real ACP lifecycle/standing-instruction/restore/UI qualification and direct screenshot publication. Candidate source and tests can be reviewed now without that login. Current-head CI must finish and genuine failures must be resolved before any ready claim. Keep Chat unregistered. Original comment by @nikhilachale on 2026-10-19T15:53:09ZContinuing existing PR6546 after fresh fetch of actual Then improve the existing actual NewCandidate driver/lifecycle regression coverage without duplicate transport/registration: use current shared ACP/persistenthost seams, fail closed on unqualified settings/restore identity, preserve native default prompt/permissions, and independently review source. Routine suites execute only in PR CI. Existing native2.164.0 auth-required failures are retained; no blind login retries/provider-key substitutions. ~540MiB disk: no dependency install/build allocation/additional deletion. Native account/UI/direct-attachment qualification remain separate and do not stop safe source/CI progress. No production or PR6509 actions. Original comment by @nikhilachale on 2026-10-19T16:06:35ZPushed Actual driver changes: strict exact-ID Resume/Reconnect; only proven host absence permits replacement/disk-history preflight, so a live first turn adopts its existing host; replacement never falls back fresh. Native history/workspace validation reuses the agent plugin. Exact2.164.0 is checked on actual launches as well as Probe. The observed ACP1/load handshake is required (stock omits AgentInfo; no identity invented). Direct config setters now obey the candidate's unqualified-settings refusal. Explicit image/context/steer gates survive native advertisement. Existing shared conversations keep history/ACK/hibernation/termination/live-reconnect ports. Native profile safety: candidate launch/replacement now requires an explicitly preprovisioned session-owned profile at AO DataDir/agents/codebuddy/chat/sessionID with the exact private ownership marker. No implicit real native-home mutation, automatic credential replacement or source-profile copying. This lab prerequisite is not shipped profile setup support; candidate remains unregistered. Tests authored through actual NewCandidate and the real detached host against an explicitly synthetic stdio executable: Start/Send/successful terminal receipt+ACK, config refusal, exact replacement/replay/private-context separation, no fresh fallback, first-turn live adoption, missing host/history preflight, auth/version/profile refusal. Additional controlled permission/interrupt coverage is being completed. These are source/transport regressions, not real CodeBuddy lifecycle proof. Routine suites remain CI-only. Migration reconciliation Independent read-only review identified and rechecked the source defects; no remaining actionable source finding in the pushed change. No compilation/suites/provider calls performed by reviewer. Current-head CI is pending and will be inspected; prior green Original comment by @nikhilachale on 2026-10-19T16:12:31ZCurrent pushed head Independent read-only reviewer confirms actual ports-compatible Controlled process tests now invoke the actual candidate through the real persistent host, using an explicitly synthetic provider. Added allow/reject/unoffered-decision refusal, pending-approval cancellation, streaming interruption, successful terminal receipts/ACK and executed immediate continuation. Review found two fixture issues: continuation raced post-turn Ready, and cancelled permission RPC remained outstanding. Both corrected: wait for post-terminal Ready, emit pinned SDK Current-head Go, Frontend, CLI, proof artifact, feeds, scan: queued. Prior25/25 at cd56c65 is historical, not this head. ImplementationComplete=false until full current-head CI is green; qualificationComplete=false. Candidate remains unregistered. Native2.164.0 account-session auth-required first failure is retained; no blind retry/key substitution. Native/AO/UI/private-instruction/child/Kill proof remains incomplete; private provider wire role unknown. Explicit session-owned native profile provisioning is a candidate prerequisite, not shipped automatic credential/profile setup. Actual UI screenshot/direct attachment unavailable. No native/AO/Electron process launched, no local suites or dependency/build allocation/deletion. Historical evidence/production/PR6509 untouched. Original comment by @nikhilachale on 2026-10-19T16:19:55ZWORKING / waiting for current-head CI. Not implementationComplete, qualificationComplete or READY_FROM_OUR_SIDE. Snapshot Fresh actual PR branch and canonical main were fetched/reconciled immediately before this snapshot and every normal push. Head Existing CodeBuddy Code TUI plus actual unregistered NewCandidate Chat driver. New source enforces attach-first live adoption, strict replacement history/identity and no fresh fallback, launch-time exact version, direct config restrictions, explicit prompt capability gates, and a preprovisioned AO-session-owned native profile. It preserves native default prompt/default permission mode and source profiles. No shipped Chat/profile setup claim.
Source driver SHA256 Current-head workflows:
Reported current-head jobs:
Every available current-head result was inspected; no failing log is available for queued jobs. Superseded ancestor-run cancellation was requested only on the two owned PR branches to release concurrency; current-head checks were never cancelled, skipped or disabled. Some old-run cancel calls returned409/not-in-progress; that was not relabeled a successful recovery. GitHub REST and GraphQL both report the current queue; hosted CI execution remains external. Next action is inspect all current-head outcomes, retrieve actual failing logs and repair genuine failures through refreshed normal pushes. Operational checkpoint stays Cleanup: no owned native/AO/daemon/Electron/audit sessions were launched, so none required termination. Production, credentials/native profiles, histories, existing evidence, unrelated controls and other workers' PRs were untouched. Parent cleanup was limited to verified unused ignored dependencies, disposable npm cache and superseded vendor copies, with source/status/lockfile checks unchanged. This worker performed no additional disk cleanup, dependency/build allocation, merge/release/deployment, or PR6509 modification/comment. All new narratives remain inline here; no new repository report/JSON/PNG evidence assets. Original comment by @nikhilachale on 2026-10-21T05:27:21ZFresh testing-only retest starting for |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Copied source evidence 2/2Historical material from original PR #6546, copied for this account migration. Source PR head when copied: Original comment by @nikhilachale on 2026-10-21T05:36:21ZCodeBuddy testing-only current-status evidence — BLOCKED / incomplete integration (2026-10-21T05:36:20.346696+00:00)
Binary SHA-256:
Fresh command/attempt receipt:
Reproduction (generic paths; selected contract is intentionally incomplete): cd <source>/backend
GOMAXPROCS=1 GOFLAGS=-p=1 GOMEMLIMIT=384MiB go build -o <runtime>/bin/ao ./cmd/ao
TMPDIR=<runtime>/tmp NODE_OPTIONS=--max-old-space-size=384 node <staged-skill>/scripts/audit_ao.mjs \
--agent codebuddy --repo <source> --ao <runtime>/bin/ao \
--local-contract <runtime>/contract.json --report <runtime>/strict-001/report \
--timeout-seconds 25 --startup-timeout-seconds 45Use the same authorized credential route privately; do not print credentials or run login. Credential presence alone remains configured. {
"schemaVersion": 1,
"agents": {
"codebuddy": {
"binary": "<native>/codebuddy",
"versionArgs": [
"--version"
],
"integration": {
"args": [
"--help"
],
"expect": "CodeBuddy Code"
},
"aoModelsPath": "agents/{agent}/models"
}
}
}Exact private contract bytes SHA-256 Completion matrix:
Every screenshot checkpoint was indexed before actions. AO UI attachment evidence: BLOCKED. Current frontend dependencies are absent; npm ci/install and symlinking/using an old frontend are prohibited. Existing UI launchers hardcode another checkout and were read only, never launched. No real safe PNG was captured; private attachment queue has zero entries and BLOCKED uploader status. No local path counts as published image evidence. Action/result states below remain separate from the attachment status.
Current-head CI (GitHub helper readback; all returned head SHAs match tested SHA):
Cleanup and unresolved handoff:
Original comment by @nikhilachale on 2026-10-23T16:31:00ZRe-review against harness skill #7081 — changes requiredReviewed exact PR head Findings
Fresh verification and limits
Current exact-head CI is 19/25 success, 6 failures, not the older green snapshot in the description. Besides the linked failures, Current-main gate: observed main Evidence was generated outside Git under the private VPS review root. The pristine #7081 skill was retained; a separate runtime copy changed only its hardcoded temporary state prefix from Screenshot evidence is now PUBLISHED: all 10 captured PNGs and raw results on the separate evidence branch, pinned to Disposition: not ready for approval under #7081. Fix the AO issues, remove/split the excluded diff content, rerun exact-head CI and the authenticated native/UI gates, then obtain a fresh review. Original comment by @nikhilachale on 2026-10-23T16:55:12ZReview evidence: screenshots and raw results (#7081)Publishing the retained 2026-10-23 VPS review evidence using the same separate evidence-branch approach as #7093. This is not a new test run and changes no verdict. Reviewed product head: All 10 PNGs are embedded below, with immutable URLs. Each published PNG was fetched back and its SHA-256 matched the captured file.
Interpretation: Already installed is not an Install-button pass. The Models-tab runner assumes a catalog, while the backend correctly supports freeform models; the separately verified UI issue is missing usable direct entry in New Task. Update was NOT_RUN. Authenticated prompt, role, usage and successful history/restore qualification remain BLOCKED/SKIP. The negative 500 probe is not successful restore or process-kill recovery proof. The CodeBuddy Login runner FAIL is retained as a selector observation. The final manual Account control check timed out, so the review does not assert a separately proven missing-setup-button defect. PNG bytes are unchanged. Text files have ANSI styling removed and private test-root prefixes normalized. Selected text and screenshot OCR were scanned for credential patterns with no matches; no private env/config files were published. SHA-256 manifest. Captured UI checkpointsOriginal comment by @nikhilachale on 2026-10-23T17:20:02ZFollow-up: native login and Z.ai/MiniMax configuration optionsChecked the published @tencent-ai/codebuddy-code 2.164.0 package, retained native --help and official CLI docs. This is package/source and documentation verification, not an authenticated provider run. Native login: launch Third-party keys: CodeBuddy documents Z.ai and MiniMax therefore have a documented protocol/configuration route; a valid matching provider key, plan, model and endpoint still need a live check. MiniMax documents its Anthropic-compatible endpoint at AO wiring gaps at c9e14d9:
Required follow-up: offer native login/configuration in AO, keep it in the session's intended native profile/environment, verify the selected provider, and repair the model picker. The prior automated Login selector failure remains distinct from a manually reproduced button finding; this comment establishes the documentation-only source wiring and the native options. No credential file was inspected, no key was entered, and no login/logout or real provider call was performed. Support is documented; the user's exact Z.ai/MiniMax keys are not live-verified by this check. Original comment by @nikhilachale on 2026-10-23T19:24:21ZCodeBuddy Code: login, auth and model fixes pushed at 81ac436; includes main b13b951. Evidence is attached below. Full local and GitHub validation is still running; this is not a merge-ready verdict. Reviewed against harness skill7081.
Native first attempts · Mastra corrected native result · Probe-byte equivalence. Real Electron/UI capture revision: 8a7252b. The current head changes only a test query option and, for Mastra, a method comment after that proof; runtime behavior is unchanged. Source provenance. The first practical UI request ran native2.173 because the private Node toolchain PATH shadowed the pinned2.164 prefix. Those screenshots remain labeled2.173. After correcting only private PATH precedence, an API retry on the same daemon launched native2.164 and its terminal mux showed the login chooser. The retry is API/native proof, not a second UI-form proof. Account action (CodeBuddy final settings capture uses native2.173; native2.164 login capture follows): Native login chooser, without selecting an account or entering a key: UI report · Runtime proof · All artifacts and reproduction inputs · SHA256 manifest. Limitations: no successful provider turn inside an AO UI session, full lifecycle/restore/permission-enforcement qualification, or cross-platform native-provider proof is claimed. CodeBuddy's explicit Open setup /login reopening was not executed while its chooser was already active; that action has source/unit coverage. The earlier CodeBuddy outgoing-request timing incident and native-version drift are retained in the evidence. Existing Chat candidates remain gated/unregistered. Native checks used bounded temporary environments; keys, raw provider replies and credential files are not attached. The complete70-file public evidence bundle was read back with HTTP200 and matching SHA256 hashes. |
🏆 Review leaderboardNov 5–12, 2026 · UTC
Ranked by distinct external PRs reviewed, then review rounds, then PR comments. Self-activity and bot activity are excluded. Show 6 more reviewers
|
Account migration verification
|
Resolve conflicts with main while keeping main's daemon, API and UI
behaviour:
- ACP: keep main's model-switch check and steering negotiation; apply
the provider config validator first and gate steer/images/embedded
context on explicit capability overrides.
- Session guard: run the terminal-readiness check before main's
composer-draft check, which still runs last under its input fence.
- Session manager: take main's restore and launch signatures; keep the
serialized-input opt-in. Drop the duplicate RestoreConfig.Env field.
- Settings: keep main's auth summary and unknown-auth actions; report
CodeBuddy credentials its native inference check did not accept as
not verified.
- New Task: move direct model entry into main's TaskModelPicker, scoped
to New Task so automation pickers keep main's behaviour.
- Add settings.harness.models.directEntry to every locale with the
{{agent}} placeholder (fixes the zh-CN catalog failure).
- Renumber the CodeBuddy CHECK migration above main's latest
(20261114173149181) and burn the preview number 20261023181512240.
- Keep live-run evidence out of the diff; link docs/harnesses/codebuddy.md
from docs/README.md.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Harness skill receipt — PR #7081
|
| Step | Result | Evidence / gap |
|---|---|---|
| 0 Intake | PASS | Open PR #8202 continues #6546; continuing it. |
| 1 Compatibility | BLOCKED | docs/harnesses/codebuddy.md records 2.164.0 behaviour from historical Linux runs. Not re-observed at this head. Needs a live mac/Linux host. |
| 2 Touchpoints, TUI | PASS 13/13 required | Adapter, domain, registry, SQLite repair + migration, DTO/OpenAPI/schema enums, product label, hooks, activity dispatch, terminal refresh, refresh matrix. Optional: spawn help ok; doctor-probe absent (see below). |
| 2 Touchpoints, install / auth / models | PASS 2/2, 1/1, 1/1 | npm plan pinned to @tencent-ai/codebuddy-code@2.164.0; native login plan; direct-entry model catalog. |
| 2 Touchpoints, branding | FAIL 0/2 required | No assets/agents/codebuddy.* and no AgentAvatar.tsx entry. Needs an official logo with its licence/source; not fabricated. |
| 2 Touchpoints, docs | PASS (optional) | docs/harnesses/codebuddy.md, docs/README.md index (added), agents index. |
| 2 Chat surface | SKIP / open | Scope is TUI-only, but the PR ships an unregistered chatdriver/codebuddyacp package plus shared ACP changes. The skill says "no unregistered drivers" and asks for Codex/Claude tests on shared ACP edits. Decision requested. |
2 doctor-probe (optional) |
OPEN | Binary name matches the ID, so the default PATH probe applies. A pinned --version spec was not added because no recorded proof of the flag exists. |
| 3 Contract | BLOCKED | No contract was written or committed. Needs an authorized mac/Linux audit host. |
| 4 Live audit | BLOCKED | Not run (Windows host; no VPS). Native login, TUI lifecycle, restore, hooks and usage remain unqualified at this head. |
| 5 UI audit | BLOCKED | Not run. Checkpoints 1–9 need screenshots from the real desktop app on mac/Linux. |
| 6 Fix / hand-off | OPEN | The rows above remain. |
CI
The workflows on a0866c8eaa (CI, gitleaks, Harness release feeds, Public boundary) are action_required. A maintainer must approve fork-PR workflow runs before any check reports. No local test runs were made on this host.
Still required before merge: maintainer-approved CI passing on this head, a fresh review, independent maintainer approval, and live TUI + UI audit evidence from a mac/Linux host.
nikhilachale
left a comment
There was a problem hiding this comment.
AO review: changes requested
Reviewed head a0866c8eaa against main (merge base 28bc83fd95). The CodeBuddy adapter, auth probe, history guard, migration and installer pieces follow existing harness patterns. Three problems need fixing before this is ready. Each one has its own inline comment:
- Serialized input drops the user's keystrokes (
session_input.go). Terminal keystroke leases are held while queued, so the new rule refuses the second key whenever two frames overlap. - Every not-ready surface is reported as a pending permission decision (
sessionguard/guard.go). A mid-turn session and an unsent draft both come back asSESSION_AWAITING_DECISION, and the composer-busy classification is lost. - Launch-time version probing now applies to every registered native-ACP harness (
nativeacp/driver.go), even though it only serves the unregistered CodeBuddy candidate.
Optional, not blocking:
TaskComposernow passesallowDirectEntryfor every local task. That turns on freeform model IDs in New Task for all direct-entry harnesses (Claude Code, Codex, OpenCode, ...), not just CodeBuddy, and it flips an existing test expectation. If that is intended, call it out in the PR description. Otherwise, scope it to CodeBuddy.settings.harness.models.directEntry("Configure its provider in {{agent}} first") now shows for any direct-entry harness with an empty catalog, and its wording is CodeBuddy-specific.Manager.serializedInputentries are never deleted when a session ends.repairRenumberedCodeBuddyMigrationHistoryruns on every startup for every database that hascodebuddyin its schema. If a future migration drops or renamesversion_refresh, either harness-release table, or either trigger, every install will fail with "partial schema; refusing preview repair". Consider marking the repair as done, or limiting it to identifiable preview ledgers.
I did not run any tests or programs. This is a static review of the diff.
A terminal holds one input lease per queued data frame, so refusing every second lease on a guarded harness dropped the user's own fast typing, key repeats and chunked pastes. Raw leases now stack as before for every harness. A guarded paste is admitted only while its delivery's lease is the session's sole writer, and new input is refused only until that paste's lease is released. A delivery under an exclusive operation holds no lease and leaves input open afterwards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…changed - Guard: a CodeBuddy draft or queued keystrokes now suppress as composer-busy (retryable, ErrComposerBusy), an active turn as busy (new retryable ErrSessionBusy / SESSION_BUSY, retried by report delivery), and only a native decision as awaiting decision. Send and after-start delivery no longer treat either busy outcome as delivered. - Rename the paste-guard port method to ValidateTerminalPaste. main's daemon admission duck-types ValidateTerminalMessage(message, screen), so the shared name routed Hermes through the paste guard and CodeBuddy through daemon admission, each with swapped arguments. - nativeacp: Launch no longer runs VersionProbe; registered bindings probe at admission only, as on main. The CodeBuddy candidate rechecks its exact binary in its own Configure. - Scope typed New Task models and the Models hint to CodeBuddy so other direct-entry harnesses keep main's catalog picker. - Stop the preview ledger repair once CodeBuddy's migration is recorded, so a later change to 214/215 objects cannot block startup. - Fix the input-checker test for main's DeliverWithComposerCheck. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Optional notes from the review of
No tests were run locally (Windows host). The fork-PR workflows still need maintainer approval to run on this head. |
nikhilachale
left a comment
There was a problem hiding this comment.
AO review: approved
Re-reviewed head 1dc1b6fad2 (fix commits 42a9bae5d2 and 1dc1b6fad2 on top of the previously reviewed a0866c8eaa). Every finding from the previous review is resolved:
- Keystroke leases stack again.
AcquireSessionInputnow refuses only while a guarded paste is in progress (guardedPaste).beginGuardedPasteadmits a paste only when the caller holds the sole lease, and the flag clears on the last release. While keystrokes are still queued, a paste is refused as a retryable composer-busy instead of dropping keys. The new test covers overlapping raw leases before and after a paste, and a paste with no lease under an exclusive operation. - Refusals are now distinguished. The plugin joins
ErrTerminalComposerDraftorErrTerminalTurnActiveontoErrTerminalMessageNotReady. The guard maps them toSuppressedComposerBusy,SuppressedBusyandSuppressedAwaitingUser.sendanddeliverStartedInputmap those toErrComposerBusy, the newErrSessionBusy(SESSION_BUSY) andErrAwaitingDecision. Report delivery treats both busy cases asErrOrchestratorBusy. Each case has a test. - Shared native-ACP launch is unchanged. The launch-time version recheck moved into
codebuddyacp's ownConfigure. A test now asserts that sharedLaunchruns no extra version command.
The optional items were also handled. Typed model entry in New Task and the Settings direct-entry message are limited to CodeBuddy via acceptsTypedNewTaskModel. guardedPaste entries are removed on release. The preview migration-ledger repair now stops for good once either CodeBuddy migration number is recorded, and a test covers a later canonical schema change. Renaming the paste guard to ValidateTerminalPaste also avoids a collision with the existing daemon ValidateTerminalMessage admission contract, and a registry test enforces that.
No changes requested. I did not run any tests or programs. This is a static review of the diff.

















Code changes: +1233 -24
Tests: +1693 -25
Others: +1058 -3
What
feat: integrate CodeBuddy Code foreground TUI sessions
Original PR description, preserved
CodeBuddy Code login, auth verification and model-entry fixes at 81ac436. Latest integrated main: b13b951.
Native Set up now opens CodeBuddy and the Open setup action sends /login. Provider verification uses a bounded, tool-free native request with hooks, function mods, MCP, persistence and updater/background work disabled for that check.
New Task accepts supported direct model IDs, and Models explains native freeform selection instead of implying an available catalog. Login, runtime and auth checks use the same canonical AO data/profile root, including relative AO_DATA_DIR overrides.
Current full validation is in progress; merge readiness is not claimed.
Native provider proof used Mastra0.45.0 and CodeBuddy2.164.0; CodeBuddy practical UI2.173 and the corrected2.164 API/native retry are separately identified in the evidence comment. Full lifecycle, restore and cross-platform native-provider qualification remain separate from these fixes.
Current fix and evidence status.
The five pre-existing historical binary assets remain outside line counts.
Current scope remains foreground TUI. Successful provider authentication, complete live lifecycle qualification and merge readiness must be assessed from the current evidence comment; historical checks below do not qualify this head.
Preserved description and evidence from earlier source revisions (historical)
Current continuation:
c9e14d9661257a429530aa0213e27bc0c9ab6e7eincludes canonical maind1f210d9e7e57f7dff5a52bcfc7887d58ab7da6c. Reviewed driver source fixes pushed; current-head CI pending, qualification incomplete and Chat shipping gated. Exact completion/remaining-work snapshot.Binary assets in this source snapshot: 5 (excluded from line counts).
Foreground TUI with native Default/manual permissions; Chat/ACP, Auto, Accept Edits, Bypass, background work, reviewer and handoff excluded.
Current status
Current source snapshot:
cd56c657748d75054d5a50e7b1aff8bed4475ca3(includes PR-host main55b02b848dd3f05f4d010fc5d603d5e9e6217669, including Memcode 0202 and per-folder accounts 0210-0212). CodeBuddy now uses migration 0215; the 0207 draft collision is guarded and tested. An unregistered ACP candidate is included; Chat/ACP remains outside supported and registered scope pending native qualification. A focused fix removes a redundant ActionSetup parameter flagged by Linux lint. All 25/25 exact-head checks pass across Go, Frontend, CLI E2E, harness proof, harness release feeds, and gitleaks; AO review approved this head with no findings. GitHub reports MERGEABLE. Focused SQLite and migration tests, registry/activity, installer/auth and API tests, Go build/vet, Product UI typecheck and 160 tests, and docs build pass locally. Native CodeBuddy login/TUI at this source remains NOT_RUN; independent GitHub approval remains required.The earlier reporting-only reconciliation used isolated source worktrees and did not rerun CodeBuddy. This continuation built and tested the current source locally, but did not perform a new native CodeBuddy login or TUI run. Historical native evidence remains scoped to its recorded source and release.
Historical runtime build: Historical AO/UI source
5827f13d75b639eac6ed76f6d572b6752c060da5, released@tencent-ai/codebuddy-code@2.164.0, Node24.21.0/Ubuntu; launcher SHA256426186a82e36466d5be485f335ced1b0d664539c53b72a5f10ba3a267e60dab6. Earlier lifecycle sources/failures remain separately recorded. Report · evidence index, original receipts, image/provenance hashes. Receipt SHAs/bytes are unchanged. Linux/VPS proof is not Windows/macOS native proof. Runner SHA2568887aa2e7101b9e6d3950bfca08ffddf2e1e6c1c3f1d030c8dec2676443aecearemains historical where reported; manual/standalone proof is not a strict runner PASS.Changes since runtime proof: The harness guide records direct model IDs, supported permissions/input/history bounds and an intentional initials avatar fallback because no asset reuse terms were verified. Native/UI journeys at the current source are NOT_RUN. Current-main reconciliation preserves the integration and upstream migration ledger; current source/CI state is recorded above.
The matrix separates current verification from recorded historical passes;
NOT_RUNdoes not erase those passes. Excluded interfaces/manual model input are deliberate supported-scope decisions.Current validation and merge order
Focused CodeBuddy adapter, migration, registry and guard tests pass locally, along with Go build/vet, API and sqlc drift checks, Product UI typecheck and 160 tests, Cloud client typecheck and 29 tests, docs build, E2E typecheck, and guarded browser integration. Broad Windows runs encounter unrelated Unix/macOS fixture, symlink, and filesystem assumptions; exact-head Linux CI is the full-suite gate. Native CodeBuddy login/TUI at this source is NOT_RUN.
Migration merge gate: PR-host main includes Memcode 0202 and per-folder accounts 0210-0212; its migration maximum is 0212. CodeBuddy #6546 uses 0215, while the shared burned-version ledger reserves draft 0207 so preview databases cannot silently skip the CodeBuddy migration. The migration regression covers a database that used Open Interpreter's old draft 0207, then applies CodeBuddy 0215. Open claims include Pool #6551 at 0208, Neovate #6494 at 0209, usage-limit recovery #6717 at 0213-0214, and Open Interpreter #6496 at 0216. Other open PRs #6541, #6892, and #6364 still claim 0207; their owners must coordinate numbering and the shared harness CHECK/repair paths before merging. The latest 435-open-PR survey found #6546 as the only observed 0215 claimant. Open claims are coordination inputs, not reserved versions.
Recheck PR-host main and active migration claims immediately before any merge. If 0215 lands elsewhere first, or another PR changes the shared harness CHECK/repair paths, reconcile on current main, choose a genuinely free version above its migration maximum, rerun affected tests and exact-head CI, and obtain fresh review. Do not merge #6546 until independent GitHub approval is recorded.
Historical implementation and evidence
Supersedes closed/unmerged contract-only5503 (native2.151.0). Implements current rendered input admission, native profile overrides, bounded additive instructions, exact native-ID history restore and migration0215/historical schema reconciliation. Missing/corrupt/foreign/ambiguous history fails closed; history over32MiB and instructions over64KiB are refused. Credential inventory stays configured; freeform models do not imply a catalog. Suggested prompts remain conservatively nonempty pending native resolution. CI/static output is not an initialized TUI; historical final lab used CI=false. This limited qualification is not a strict catalog/auth runner pass. Historical source 5827f13 had 23/23 green checks; evidence 36f0605 had 5/5/150 fixtures. Earlier native/login/provider/startup/static-renderer/capture, permission-cancel and freed=true assertion failures remain reachable in the report.
historical receipt 1 · historical receipt 2
Reproduction and retained-original limitations
The pinned reports/JSON retain action/result, file/token effects, process identity, cancellation, native-history continuity and capture assertions. A complete sanitized executable reproduction bundle is not established for every manual helper: exact helper bytes/hash and invocation, applicable local-contract bytes/hash with probe argv and interrupt/readiness/draft-cleanup settings, and complete native/AO fingerprints are unavailable where not recorded in the linked receipts; recoverability of those original inputs is unknown. No missing command, contract, hash or result is invented. Later reproductions must use a new attempt and cannot replace original failed/missing evidence.
Recorded owned-process/session/daemon/Electron cleanup is historical. Source worktrees, native profiles/history, dirty scratch workspaces, binaries and raw logs were reported retained privately; a complete current inventory/location/hash and recoverability of every original class are unavailable in the public record. Current recoverability is unknown; this reporting fix reconstructs no missing input and silently substitutes none. Share sanitized artifacts only; exclude credential stores, raw DBs and provider-profile directories. Preserve the retained failures and original screenshots.
Latest reconciliation: #6546 (comment)
ACP continuation at
b499e9beb17668bbe1253649f9a0ea2e32b5ee91: unregistered 2.164.0 nativeacp candidate with bounded additive instructions and strict settings admission. Chat remains unavailable pending authenticated native lifecycle and AO UI qualification; current-head CI pending. Routine validation for this continuation runs only in PR CI. Prior source/validation statements above remain historical.Latest ACP candidate status (BLOCKED, Chat unregistered): #6546 (comment)
Why
The contributor is moving this harness submission to @milesatao-svg. The linked source preserves the implementation and review history.
Before / After
81ac43669ba88052c880b4f66e856a8e6174f44181ac43669ba88052c880b4f66e856a8e6174f441Original product behavior and existing UI evidence are included in the preserved description and copied evidence comments.
How
Copy the source head into
milesatao-svg/agent-orchestrator:codex/copy-pr-6546-codebuddyand target upstreammain.Testing
Historical test results and screenshots are reproduced in the evidence comments with their original sources. Fresh validation is tracked by this PR's GitHub checks.
Checklist
Account migration verification
81ac43669ba88052c880b4f66e856a8e6174f441.milesatao-svg/agent-orchestrator:codex/copy-pr-6546-codebuddy. Base:main.