Improve Background Tasks module documentation - #19628
Open
agriffard wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
hishamco
requested changes
Jul 31, 2026
| public sealed class TenantMaintenanceBackgroundTask : IBackgroundTask | ||
| { | ||
| public Task DoWorkAsync( | ||
| IServiceProvider serviceProvider, |
Member
There was a problem hiding this comment.
We need to use IServiceScopeFactory instead
Co-authored-by: Hisham Bin Ateya <hishamco_2007@yahoo.com>
MikeAlhayek
requested changes
Aug 5, 2026
Comment on lines
+25
to
+53
| ```csharp | ||
| using Microsoft.Extensions.DependencyInjection; | ||
| using Microsoft.Extensions.Logging; | ||
| using OrchardCore.BackgroundTasks; | ||
|
|
||
| namespace MyModule; | ||
|
|
||
| public interface ITenantMaintenance | ||
| { | ||
| Task RunAsync(CancellationToken cancellationToken); | ||
| } | ||
|
|
||
| public sealed class TenantMaintenance : ITenantMaintenance | ||
| { | ||
| private readonly ILogger _logger; | ||
|
|
||
| public TenantMaintenance(ILogger<TenantMaintenance> logger) | ||
| { | ||
| _logger = logger; | ||
| } | ||
|
|
||
| public Task RunAsync(CancellationToken cancellationToken) | ||
| { | ||
| cancellationToken.ThrowIfCancellationRequested(); | ||
| _logger.LogInformation("Tenant maintenance completed."); | ||
|
|
||
| return Task.CompletedTask; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
this does not need to be part of the example. it lengthen the example for no reason. The IBackgroundTask implementation is enough
Co-authored-by: Mike Alhayek <mike@crestapps.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
python -m mkdocs build --strict