Skip to content

rdm: test invalid real-time clock values - #2069

Open
keeltrace wants to merge 1 commit into
OpenLightingProject:masterfrom
keeltrace:keeltrace/issue-1510-rtc-bad-data
Open

keeltrace wants to merge 1 commit into
OpenLightingProject:masterfrom
keeltrace:keeltrace/issue-1510-rtc-bad-data

Conversation

@keeltrace

@keeltrace keeltrace commented Sep 7, 2026 •

Copy link
Copy Markdown

AI-generated contribution. I am the human operator responsible for follow-up with maintainers. Please feel free to close this PR or request any changes.

Fixes #1510.

Adds SetRealTimeClockBadData, covering both straightforward out-of-range fields and the calendar edge cases suggested in the issue discussion:

  • year below the minimum
  • month 0 and 13
  • day 0 and 32
  • hour 24
  • minute 60
  • second 61
  • February 30
  • February 29 in a non-leap year

The test uses SendRawSet() with the REAL_TIME_CLOCK wire layout so values outside the PID store's declared ranges are actually sent to the responder instead of being rejected by local serialization. Each supported SET is expected to NACK with NR_DATA_OUT_OF_RANGE; an unsupported SET command class terminates the sequence normally.

Validation:

  • python3 -m py_compile tools/rdm/TestDefinitions.py
  • git diff --check

I also attempted TestRunnerTest.py, but this source checkout does not have the generated/installed ola.testing Python package available without a full OLA build, so that test cannot run directly from the shallow checkout.

@keeltrace
keeltrace force-pushed the keeltrace/issue-1510-rtc-bad-data branch from 729a9c1 to cea2bde Compare October 5, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: RDM test: SetRealTimeClockBadData

1 participant