Repository navigation
Conversation
keeltrace
force-pushed
the
keeltrace/issue-1510-rtc-bad-data
branch
from
October 5, 2026 01:04
729a9c1 to
cea2bde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-generated contribution. I am the human operator responsible for follow-up with maintainers. Please feel free to close this PR or request any changes.
Fixes #1510.
Adds
SetRealTimeClockBadData, covering both straightforward out-of-range fields and the calendar edge cases suggested in the issue discussion:The test uses
SendRawSet()with the REAL_TIME_CLOCK wire layout so values outside the PID store's declared ranges are actually sent to the responder instead of being rejected by local serialization. Each supported SET is expected to NACK withNR_DATA_OUT_OF_RANGE; an unsupported SET command class terminates the sequence normally.Validation:
python3 -m py_compile tools/rdm/TestDefinitions.pygit diff --checkI also attempted
TestRunnerTest.py, but this source checkout does not have the generated/installedola.testingPython package available without a full OLA build, so that test cannot run directly from the shallow checkout.