🏗️🔧：let the minified script say so in its name - #1868
Conversation
The stylesheet is built on the rule that `.min` is a claim about what is inside a file, so only the build that minifies makes one. The script was minified under the name it arrived with, which says the opposite of what had happened to it. It is `count.min.js` now, and the unminified copy does not go out beside it. The tag asking for it sits inside the block that only renders for production, so it names the minified file outright rather than deciding again in a condition that cannot be false. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5 Refs: #1867
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughProduction asset processing now minifies JavaScript into ChangesProduction asset processing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change makes the production script filename accurately reflect its minified contents while preserving the development asset and template behavior; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
OpenINFbot
added
the
🚀 Status: Commit Queue
openinf-commit-queue
Bot
removed
the
🚀 Status: Commit Queue
2 participants
#1867 minified the script but left it under the name it arrived with,
which is the one thing the stylesheet is careful not to do:
A
count.jsthat is not thecount.jsupstream serves is exactly theoverstatement that comment is about.
count.js, 5,774 bytescount.js, 9,213count.min.js, 5,774count.js, 9,213The unminified copy does not go out beside it — the pass renames rather
than adding.
The tag names the file outright
The script tag already sits inside
{% if env == 'production' %}, so asecond condition on the same thing could never be false. It asks for
count.min.jsdirectly. The stylesheet keeps its condition because its<link>is not inside such a block.What was already right
Minifying was production-only from the start; this only fixes the name.
Checked both builds rather than assumed:
Verified
/assets/js/vendor/count.min.js, that path answers200, and the old one answers 404
a beacon with
s=390 p=/, no page errorsnps verify.vendoredstill saysit matches upstream
.min.jsis left alone rather than becoming.min.min.jsnps testpassesRefs #1867
Summary by CodeRabbit