Skip to content

🏗️♻️:let the queue label take either name - #1860

Merged
openinf-commit-queue[bot] merged 1 commit into
livefrom
fix/commit-queue-label
Aug 25, 2026
Merged

🏗️♻️:let the queue label take either name#1860
openinf-commit-queue[bot] merged 1 commit into
livefrom
fix/commit-queue-label

Conversation

@DerekNonGeneric

Copy link
Copy Markdown
Member

Every label on this repository is named with an emoji and a category
except commit-queue, and that one cannot simply be renamed.

pull_request_target runs the workflow from the base branch, not from
the pull request. So renaming the label first means the queue stops
recognising it, and nothing can be landed until the fix lands — which
is itself a thing that has to be landed. Whichever order you pick, the
queue is dead in the gap.

Matching both spellings removes the ordering problem:

if: >-
  github.event.label.name == 'commit-queue' ||
  github.event.label.name == '🚀 Status: Commit Queue'

Nothing changes today. Once this is on the base branch the label can be
renamed at any moment, with no window in which the queue is deaf, and
the plain name can be dropped from here once nothing carries it.

The label also comes back off through a URL

"repos/${GITHUB_REPOSITORY}/issues/${NUMBER}/labels/commit-queue"

An emoji name interpolated raw into a path does not survive. It is
percent-encoded now, and read from the event rather than written out,
so whichever name triggered the run is the one taken back off.

Checked against the live API using the label renamed a moment ago,
apostrophe and all:

$ jq -rn --arg l '🚀 Status: Commit Queue' '$l|@uri'
%F0%9F%9A%80%20Status%3A%20Commit%20Queue

$ gh api "repos/.../labels/$(jq -rn --arg l "🙅 Type: Won't Fix" '$l|@uri')"
🙅 Type: Won't Fix

commit-queue encodes to itself, so the existing path is unchanged.

After this merges

  1. Rename commit-queue to 🚀 Status: Commit Queue. A rename keeps it
    on anything already labelled, and there is no collision because the
    new name does not exist yet.
  2. Update the one sentence in the handbook that names it
    (collections/_docs/handbook/style/commit-messages.md). It is
    accurate until the rename, which is why it is not in here.
  3. Drop 'commit-queue' from the condition above.

Verified

  • the workflow still parses as YAML, and the condition resolves to the
    string shown above
  • nps test passes

Every other label here is named with an emoji and a category. The queue
label is not, and it cannot simply be renamed: the workflow that runs
is the one on the base branch, so a rename lands before the workflow
that understands it and nothing can be landed in between -- including
the change that would fix it.

Matching both spellings removes the ordering problem. The rename can
happen whenever after this, and the plain name can be dropped from here
once nothing is labelled with it.

The label also comes back off through a URL path, where an emoji name
does not survive being interpolated raw. It is percent-encoded now, and
taken from the event rather than written out, so whichever name
triggered the run is the one removed.

Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Assisted-by: Claude-Code:claude-opus-5
@netlify

netlify Bot commented Aug 25, 2026

Copy link
Copy Markdown

Deploy Preview for gh-pages-openinf ready!

Name Link
🔨 Latest commit cf4d5ad
🔍 Latest deploy log https://app.netlify.com/projects/gh-pages-openinf/deploys/6a8e057f4ca1390008da7088
😎 Deploy Preview https://deploy-preview-1860--gh-pages-openinf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@DerekNonGeneric DerekNonGeneric added 🚀 zz-tmp: Won't Fix 📦 Type: Dependencies PRs that modify packages req'd by product in production and removed 🚀 zz-tmp: Won't Fix 📦 Type: Dependencies PRs that modify packages req'd by product in production labels Aug 25, 2026
@OpenINFbot OpenINFbot added the 🚀 Status: Commit Queue Land this pull request when its checks pass label Aug 25, 2026
@openinf-commit-queue
openinf-commit-queue Bot merged commit fe53c04 into live Aug 25, 2026
18 checks passed
@openinf-commit-queue openinf-commit-queue Bot removed the 🚀 Status: Commit Queue Land this pull request when its checks pass label Aug 25, 2026
@OpenINFbot
OpenINFbot deleted the fix/commit-queue-label branch August 25, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants