🏗️♻️:let the queue label take either name - #1860
Merged
Merged
Conversation
Every other label here is named with an emoji and a category. The queue label is not, and it cannot simply be renamed: the workflow that runs is the one on the base branch, so a rename lands before the workflow that understands it and nothing can be landed in between -- including the change that would fix it. Matching both spellings removes the ordering problem. The rename can happen whenever after this, and the plain name can be dropped from here once nothing is labelled with it. The label also comes back off through a URL path, where an emoji name does not survive being interpolated raw. It is percent-encoded now, and taken from the event rather than written out, so whichever name triggered the run is the one removed. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
OpenINFbot
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every label on this repository is named with an emoji and a category
except
commit-queue, and that one cannot simply be renamed.pull_request_targetruns the workflow from the base branch, not fromthe pull request. So renaming the label first means the queue stops
recognising it, and nothing can be landed until the fix lands — which
is itself a thing that has to be landed. Whichever order you pick, the
queue is dead in the gap.
Matching both spellings removes the ordering problem:
Nothing changes today. Once this is on the base branch the label can be
renamed at any moment, with no window in which the queue is deaf, and
the plain name can be dropped from here once nothing carries it.
The label also comes back off through a URL
"repos/${GITHUB_REPOSITORY}/issues/${NUMBER}/labels/commit-queue"An emoji name interpolated raw into a path does not survive. It is
percent-encoded now, and read from the event rather than written out,
so whichever name triggered the run is the one taken back off.
Checked against the live API using the label renamed a moment ago,
apostrophe and all:
commit-queueencodes to itself, so the existing path is unchanged.After this merges
commit-queueto🚀 Status: Commit Queue. A rename keeps iton anything already labelled, and there is no collision because the
new name does not exist yet.
(
collections/_docs/handbook/style/commit-messages.md). It isaccurate until the rename, which is why it is not in here.
'commit-queue'from the condition above.Verified
string shown above
nps testpasses