feat(native): replace GStreamer with cross-platform Rust streamer v2 - #776
Draft
zortos293 wants to merge 34 commits into
Draft
feat(native): replace GStreamer with cross-platform Rust streamer v2#776zortos293 wants to merge 34 commits into
zortos293 wants to merge 34 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
capy-ai
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
Wire Bifrost-shaped x-nv ANNOUNCE ICE credentials and native STUN binding requests so the explicit NVST path can complete authenticated UDP hole punching without WebRTC media fallback.
This comment has been minimized.
This comment has been minimized.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let packet = Buffer.concat(parts); | ||
| header.writeUInt16BE(packet.length - 20 + 24, 2); | ||
| packet = Buffer.concat(parts); | ||
| appendStunAttribute(parts, 0x0008, createHmac("sha1", remotePassword).update(packet).digest()); |
Match official Bifrost identity and order so ANNOUNCE can arm WebRtcTransport: 4/22 local ICE, V2 remote ufrag, DTLS after ANNOUNCE, and keep hole-punch STUN until the handshake completes. Co-authored-by: Cursor <cursoragent@cursor.com>
- reserve a dedicated Mjolnir UDP socket for inbound NVST video - rework RTSP probe/client and CloudMatch session request handling - thread device identity and signaling through the native streamer path Co-authored-by: Cursor <cursoragent@cursor.com>
…hannel The server stops sending video shortly after the keyframe unless the client reports over the rtcp_on_sctp_private SCTP data channel; open it with the label the server expects (not rtcp1) and send Receiver Reports/PLI. Also bundle the streamer as an .app and fix overlay coordinates so the video window composes on macOS, and add the GCM-8/AES-256-CM SRTP profiles the official client negotiates. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
capy-ai
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
A fresh authorized explicit-NVST Linux session on the final code established:
stats_channel, reliable input, partially-reliable input, andrtcp_on_sctp_privateopen611frames in the observed burst)The live environment did not expose an Opus SSRC and used a dummy SDL audio driver, so it does not prove audio-device output. It also did not produce a live packet-loss event, so NACK interoperability remains covered by frozen wire-layout/reordering tests rather than live loss injection.
The final source passes:
cargo fmt --all -- --checkcargo test --workspace(147 unit/integration tests plus doc-test targets)cargo clippy --workspace --all-targets -- -D warningsx86_64-pc-windows-msvcandaarch64-pc-windows-msvcaarch64-apple-darwinbackend type-check/Clippy validationnpm run lint(zero warnings)npm run typechecknpm test(726 passing)npm run buildnpm run native:buildgit diff --checkRemaining hardware acceptance
Real-device acceptance is still required for Media Foundation/D3D11/WASAPI and endpoint/device-loss behavior on Windows x64 and ARM64, V4L2/VA-API/Vulkan/PipeWire/ALSA device-loss paths on representative Linux systems, and VideoToolbox/Metal/CoreAudio fallback behavior on macOS hardware. Live server delivery of Opus and the proprietary input handshake is also still required before those session capabilities can be called operational; the implementation now reports them unavailable instead of silently claiming success.