feat(domain): add ModelSize value object - #229
Open
utkarsha741 wants to merge 1 commit into
Open
Conversation
Consolidates the loose params/size_bytes fields on ModelVariant into a single immutable ModelSize value object with formatting helpers (e.g. '8B', '4.7GB'). Updates the info CLI display and JSON-output tests to match. Closes OpenAgentHQ#98
Author
|
Hi @himanshu231204 , just following up on this PR whenever you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the loose
params/size_bytesfields onModelVariantinto a single immutableModelSizevalue object with formatting helpers (e.g. '8B', '4.7GB').Changes
ModelSizevalue object (frozen Pydantic model) indomain/model.pyModelVariant.params/size_byteswith a singlesize: Optional[ModelSize]fieldinfoCLI command to useModelSize.__str__for displaytest_cli_json_output.pyfixture to build variants withModelSizetests/unit/test_model_size.pycovering formatting and immutabilityTesting
pytest -q— 618 passed, 4 skippedruff check,ruff format,mypy --strict,banditall passCloses #98