Repository navigation
fix(ci): declare least-privilege permissions on the audit workflow - #76
Merged
Merged
Conversation
Code scanning flagged actions/missing-workflow-permissions: audit.yml was the only workflow in the repository without a permissions block, so the job inherited the repository default token scope. Every step only reads the checkout and runs npm against a manifest it synthesizes itself, so contents: read is sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the open code scanning alert
actions/missing-workflow-permissionsat.github/workflows/audit.yml:40.audit.ymlwas the only workflow in the repository without apermissionsblock, so its job inherited the repository default token scope. Every step in it reads the checkout and runsnpm auditagainst a manifest it synthesizes itself, socontents: readcovers it.