Repository navigation
Exchange sediment and particle DIC with every carbonate replicate - #458
Open
ali-ramadhan wants to merge 2 commits into
Open
ali-ramadhan wants to merge 2 commits into
ali-ramadhan wants to merge 2 commits into
Conversation
The carbon-tracking `SimpleMultiG` sediment and the `SugarKelp` particles exchange carbon with a tracer named `DIC`, which a replicated or labelled carbonate system doesn't have (it has `DIC1`, `DIC2` or `DIC_control`, ...), so these couplings failed with `FieldError: type NamedTuple has no field DIC`. The couplings now ask the biogeochemistry which tracers to exchange with, `tracer_replicates(bgc, name)`, which is just `name` unless the biogeochemistry replicates it, and a carbonate system returns the `DIC` of every replicate. The flux depends only on the sediment or the particles, so every replicate gets the same flux and evolves exactly as the single system does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
`test_PISCES.jl` imports PISCES's `NitrateAmmonia` into `Main`, so in the full test suite the new sediment test built its nutrients from PISCES's type and failed with a `MethodError`. `LOBSTER` builds its own nutrients. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Collaborator
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #451.
The carbon-tracking
SimpleMultiGsediment and theSugarKelpparticles exchange carbon with a tracer namedDIC. A replicated or labelled carbonate system has noDIC: it hasDIC1andDIC2, orDIC_control, ….So the couplings now ask the biogeochemistry which tracers to exchange with: