Repository navigation
Added Dissolving Particles - #448
Open
johnryantaylor wants to merge 5 commits into
Open
johnryantaylor wants to merge 5 commits into
johnryantaylor wants to merge 5 commits into
Conversation
Added DissolvingParticles as a type of active particle. This module can be used to model dissolving OAE feedstock or secondary mineral precipitates.
The docs build expects generated/dissolving_particles.md, but the Buildkite examples step uses its own hardcoded list, so the example was never generated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jagoosw
reviewed
Oct 21, 2026
jagoosw
reviewed
Oct 21, 2026
jagoosw
reviewed
Oct 21, 2026
jagoosw
reviewed
Oct 21, 2026
jagoosw
reviewed
Oct 21, 2026
jagoosw
reviewed
Oct 21, 2026
jagoosw
reviewed
Oct 21, 2026
jagoosw
reviewed
Oct 21, 2026
Edits based on Jago's review
Adds optional required tracers upon which the sinking speed and dissolution rate can depend. E.g. sinking might depend on the water density and dissolution might depend on the saturation state.
Collaborator
Author
|
@jagoosw, I made the changes that you recommended in this review. This includes adding required_tracers so that the sinking speed and the dissolution rate can depend on model fields. Can you have a look at that part to see if it makes sense? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added DissolvingParticles as a type of active particle. This module can be used to model dissolving OAE feedstock or secondary mineral precipitates.