Skip to content

Avoid adding monitor sink when not intended#453

Open
PhilipFackler wants to merge 1 commit into
developfrom
PhilipFackler/fix-disabled-monitor
Open

Avoid adding monitor sink when not intended#453
PhilipFackler wants to merge 1 commit into
developfrom
PhilipFackler/fix-disabled-monitor

Conversation

@PhilipFackler

Copy link
Copy Markdown
Collaborator

Description

This fixes a bug in the dynamic simulation app that was adding a console sink to the monitor when no output file is specified.

Proposed changes

Only add the output file from the solver json file if it is non-empty.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • [N/A] There are unit tests for the new code.
  • [N/A] The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • [N/A] I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

@PhilipFackler PhilipFackler added the bug Something isn't working label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants