EMT Universal Line Model Documentation#451
Draft
lukelowry wants to merge 9 commits into
Draft
Conversation
b0e2958 to
5e4a86e
Compare
5e4a86e to
ce2df95
Compare
9f42d0c to
a94de20
Compare
Collaborator
Author
|
@pelesh, I made this PR draft so you can see the range of complexity for the models and their needs. An open-source ULM ( Discuss later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves documentation for EMT line models and adds documentation for other models needed to implement the most capable version of the Universal Line Model (ULM).
Proposed changes
Linedocumentation forLineLumpedandLineDistributed, replacing the oldBranchline docs (existing model documentation functionally unchanged)Operatorsgroup for the reusable blocks the models build onRational(VectorFit,StateSpace) for empirical f.d. transmission line modelsShift(Delay,Propagation) for distributed parameter modelingCoordinate(Park,DQZ)Component(Bus,Line,Load,Source) andOperatorsChecklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
A convention is needed to document components composed of other components. Especially how to document 'internal ports', which depends on how we go about implementation.
If the 'Operators' concept is disliked, we can move under Components. It's just a conceptual split.