Add data dictionary methods - #112
Conversation
|
@nadineisabel Should I add more validation in the library eg. only allow field, label, description (and data_type?) given that it looks like this won't be added to the CKAN call? If data_type is allowed, should I validate the value (eg. only allow "numeric", "text" and "timestamp without time zone")? |
|
Nice! This is exciting. Thoughts below: On the keys, no, leave it open. Extra keys are allowed on purpose in the schema so I'd rather the library match that. On It may be worth adding to the docs too. @alexandru-m-g confirmed datapusher+ re-infers types on every upload, so for anything going into the datastore that way Cc @danmihaila as well |
|
@nadineisabel I've added data_type validation |
nadineisabel
left a comment
There was a problem hiding this comment.
Looks good to me. Cc @alexandru-m-g and @danmihaila.
This can be used like this: