Repository navigation
[19.0][FIX] base_tier_validation_forward: gap between Reject and Forward - #74
Merged
OCA-git-bot merged 1 commit intoOct 7, 2026
Conversation
The Forward button had no margin, so it touched the Reject button on the validation banner. Give it the same gap as between Validate and Reject.
Contributor
|
Hi @kittiu, |
OCA-git-bot
added
mod:base_tier_validation_forward
cpemiguelhendrickfmallari-lgtm
approved these changes
Oct 7, 2026
cpemiguelhendrickfmallari-lgtm
left a comment
cpemiguelhendrickfmallari-lgtm
left a comment
There was a problem hiding this comment.
Code review. One-line change: ms-1 on the Forward button, which gives the same 4px gap as me-1 on Validate. It's in the forward module's own template, so it doesn't touch what #23 changes. LGTM.
Contributor
Author
|
/ocabot merge patch |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 6ec2668. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Forward button had no margin, so it touched the Reject button on the validation banner. It now has the same 4px gap as between Validate and Reject (measured in a browser).
Only the button class changes, so it merges cleanly with #23 (banner icons) and #27 (Change Reviewer button).
before:
