[18.0][IMP] rma: allow to confirm picking without rma access rights

[twalter-c2c]

When RMA is installed, stock users without read access on rma model can hit an access error while confirming pickings, even if they never use RMA directly.

[OCA-git-bot]

Hi @pedrobaeza, @chienandalu,
some modules you are maintaining are being modified, check this out!

[grindtildeath]

Pre approving, LG

[victoralmau]

Another approach to fix the same problem: #614

[twalter-c2c]

Another approach to fix the same problem: #614

It is difficult to say which approach should be used. I would appreciate @pedrobaeza's opinion on that.

[pedrobaeza]

Yes, I'm asking for just the sudo in #614, so I think this one seems correct. Not seen both tests to see which one is more focused and concise for the exact problem though.

[victoralmau]

Personally, I don't like this solution, because even though it works (that method is always called with sudo()), it simply hides the real problem (if the user call the action doesn't have access to one of the fields, an error occurs), which happens in this case with RMA but could happen with others as well (I'll try to check if there are any similar cases, for example, with mrp).

[pedrobaeza]

@victoralmau I think this solution is acceptable. There's no hiding at all, as we just want to confirm the picking without errors. Is there any drawback that I'm not seeing?

[victoralmau]

@victoralmau I think this solution is acceptable. There's no hiding at all, as we just want to confirm the picking without errors. Is there any drawback that I'm not seeing?

The solution is correct; we'll simply be applying sudo() to all those moves, and while that might have some side effects, I don't think they'll be significant.