Skip to content

[18.0][ADD]: rma_sale_stock_picking_group_by_partner_by_carrier: glue module - #571

Open
StephaneMangin wants to merge 1 commit into
OCA:18.0from
acsone:18.0-add-rma_sale_stock_picking_group_by_partner_by_carrier
Open

[18.0][ADD]: rma_sale_stock_picking_group_by_partner_by_carrier: glue module#571
StephaneMangin wants to merge 1 commit into
OCA:18.0from
acsone:18.0-add-rma_sale_stock_picking_group_by_partner_by_carrier

Conversation

@StephaneMangin

@StephaneMangin StephaneMangin commented Apr 1, 2026

Copy link
Copy Markdown

Problem

stock_picking_group_by_partner_by_carrier replaces the standard sale.order.picking_ids (One2many via sale_id) with a Many2many computed from move_ids.group_id.sale_ids.

It also adds a sale_ids (Many2many) field on procurement.group.

However, rma_sale._prepare_procurement_group_vals() only sets sale_id (the Many2one) on the procurement group — it does not populate sale_ids (the Many2many).

As a result, stock.picking._compute_sale_ids()move_ids.group_id.sale_ids returns an empty recordset, and the RMA return picking becomes invisible from the SO.

Standard Changes
sale.order.picking_ids One2many('stock.picking', 'sale_id') Many2many (computed)
stock.picking → SO link sale_id (computed from group_id.sale_id) sale_ids (computed from move_ids.group_id.sale_ids)
procurement.group → SO sale_id (Many2one) sale_id + sale_ids (Many2many)

rma_sale only writes sale_id → the M2M path is broken.

@StephaneMangin

Copy link
Copy Markdown
Author

An other problem with the module rma_sale_mrp occurs...

@StephaneMangin
StephaneMangin deleted the 18.0-add-rma_sale_stock_picking_group_by_partner_by_carrier branch April 1, 2026 13:58
@StephaneMangin
StephaneMangin restored the 18.0-add-rma_sale_stock_picking_group_by_partner_by_carrier branch April 1, 2026 14:12
@StephaneMangin StephaneMangin reopened this Apr 1, 2026
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant