Repository navigation
Conversation
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of
mis_builder_budgetfrom 19.0 to 20.0, as per the migration guide.Part of #843. Depends on #842 (
mis_builder), referenced fromtest-requirements.txtin a[DON'T MERGE]commit, so the "Detect unreleased dependencies" check fails on purpose. That commit must be dropped once #842 is merged.Changes:
20.0.1.0.0and make the module installable.security/*.xmlfiles (ir.model.accessand globalir.rulerecords) tosecurity/ir.access.csvwithupgrade_code19.4-00-ir-access. The xmlids are kept: the multi-company rules become restrictions without group.migrations/20.0.1.0.0/pre-migration.py, the same as in [20.0][MIG] mis_builder: Migration to 20.0 #842 formis_builder: it drops the xmlids still pointing toir.model.access/ir.rule, so thatir.access.csvcan load. Without it, a database where those xmlids keep the legacy model fails on update withfound record of different model ir.model.access. Tested on a database seeded that way: it fails without the script and updates with it. Not tested yet on a database upgraded from 19.0.copy=Trueonmis.budget.by.account.item.name: since 20.0, Char fields namednameare copied with a " (copy)" suffix unless they setcopy, so the labels of the items were changed when duplicating a budget.test_copynow checks the labels.env.clear()is deprecated in 20.0: replaced byenv.transaction.clear()in the tests.fa-bars->menu(Material Symbols).dict()calls to literals (C408) and nestedif(SIM102).ClassVarannotations ornoqaare added forRUF012on_inherit. The rule is ignored for Odoo >= 20.0 in the repository template (OCA/oca-addons-repo-template#376, proposed for this repository in Update dependency https://github.com/OCA/oca-addons-repo-template to v1.48 (20.0) #852). Until it is merged, theruffpre-commit hook reportsRUF012on this module..pre-commit-config.yaml:mis_builder_budgetleaves the non-installable list;mis_builderandmis_builder_demoare added, as they are still not installable on 20.0.The 16 tests pass on a 20.0 database with
mis_builderfrom #842.