Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
missing_utility; trueand equivalentbash -cwrappers return exit code 0 while the shell reports a missing executable. The existing masked-success hints do not cover that case. Nmap can also return 0 after failing to resolve a malformed target argument; that is not evidence that hosts are down. In addition, a zsh missing-command diagnostic is currently misread as a command named1.Add bounded, advisory recovery hints for those observed shapes, invalid external API query syntax, empty/non-JSON responses, and unsupported command options. Preserve every original exit code and output. There are no retries or additional tool executions.
Related Issue
Searched the issue/PR queue for masked missing-command failures and invalid search-query recovery. The separate exit-attribution effort #94360 concerns nonzero statuses; this patch is independent and applies to exit-0 diagnostics and recovery hints.
Type of Change
Changes Made
How to Test
Before patching: seven new recovery cases failed; the Nmap case was separately demonstrated red. After patching: 46 tests passed, one Linux-only test skipped on macOS. A test through the real registry and terminal backend verifies that the exit code remains 0 and the diagnostic hint reaches the final result.
Limitations
Hints remain advisory: output can contain quoted diagnostics. Matching is bounded to the existing 4,000-character window; shell-carrier inspection is capped at three levels. This does not execute Nmap or contact Shodan during testing, change approval policy, or claim improved model task success.
Checklist
python scripts/check: all 14 checks pass on this branch.Only synthetic reproductions are included. No private session, credentials, host inventory or security scan output is published.