Repository navigation
Conversation
Author
|
Closing: fixed at the source — vectorize-io/pg0#38 (pg0 0.15.2) handles pid reuse after reboot, making this warning layer moot. See #110838. |
13 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(hindsight): warn when daemon fails due to stale pg0 PID
Summary
Resolves #110838.
When the Hindsight embedded PostgreSQL daemon fails to start after an OS reboot due to a stale PID (
vectorize-io/pg0#37),_daemon_start_worker()inplugins/memory/hindsight/__init__.pypreviously caught the exception and silently logged it only into$HERMES_HOME/logs/hindsight-embed.log. As highlighted in #110838,_check_local_runtime()still reported the runtime as available, leaving users unaware of the silent failure.Following the discussion with @KeyArgo in #110838:
Failed to start embedded PostgreSQLandInstance already runningerrors in_daemon_start_worker().logger.warningand a console stderr notice (⚠ ...) directing users to verify port 5432 and inspectpostmaster.pid.tests/plugins/memory/test_hindsight_provider.py.